[release-5.0] OCPBUGS-125793: Add opt-in kube-rbac-proxy sidecar for pprof endpoint (AWS)

[openshift-cherrypick-robot]

This is an automated cherry-pick of #1502

/assign perdasilva

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 6b370914-44eb-44c0-8b77-612775a439af

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci-robot]

@openshift-cherrypick-robot: Jira Issue OCPBUGS-66932 has been cloned as Jira Issue OCPBUGS-125793. Will retitle bug to link to clone.
/retitle [release-5.0] OCPBUGS-125793: Add opt-in kube-rbac-proxy sidecar for pprof endpoint (AWS)

Details

In response to this:

This is an automated cherry-pick of #1502

/assign perdasilva

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-125793, which is invalid:

• release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #1502

/assign perdasilva

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[perdasilva]

/jira refresh

[openshift-ci-robot]

@perdasilva: This pull request references Jira Issue OCPBUGS-125793, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.0.0) matches configured target version for branch (5.0.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
• release note type set to "Release Note Not Required"
• dependent bug Jira Issue OCPBUGS-66932 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
• dependent Jira Issue OCPBUGS-66932 targets the "5.1.0" version, which is one of the valid target versions: 5.1.0
• bug has dependents

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[damdo]

/approve
/lgtm

[openshift-merge-bot]

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-operator
/test e2e-aws-ovn
/test e2e-aws-ovn-upgrade
/test e2e-metal-ipi
/test e2e-metal-ipi-ovn-ipv6
/test e2e-metal-ipi-virtualmedia

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damdo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [damdo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[perdasilva]

/retest e2e-metal-ipi-ovn-ipv6

[perdasilva]

/test e2e-metal-ipi-ovn-ipv6

[damdo]

/retest

[perdasilva]

/verified by @perdasilva

1. Scaled down CVO
2. Updated the machine-api-operator deployment adding the --enable-pprof flag to the pod template
3. Observed the pod being updated:

$ kubectl get pods -n openshift-machine-api machine-api-operator-967c47fcf-5rpct -o yaml | grep pprof
    - --enable-pprof

4. Observed machine-api-controller pod being updated:

$ kubectl get pods -n openshift-machine-api machine-api-controllers-d99668c59-57t5f -o yaml | grep pprof
    - --enable-pprof
    - --pprof-bind-address=127.0.0.1:6061
    name: kube-rbac-proxy-machine-pprof
      name: machine-pprof
    name: kube-rbac-proxy-machine-pprof

5. Setup port-forward to pprof endpoint using a metrics scrapper identity and setup port-forward

$ oc create token prometheus-k8s -n openshift-monitoring --duration=30m > /tmp/pprof-token.txt && echo "token length: $(wc -c </tmp/pprof-token.txt)"
token length: 1287

$ oc port-forward -n openshift-machine-api pod/machine-api-controllers-d99668c59-57t5f 6060:6060
Forwarding from 127.0.0.1:6060 -> 6060
Forwarding from [::1]:6060 -> 6060
Handling connection for 6060

6. curl to pprof endpoint

$ curl -sk -H "Authorization: Bearer $(cat /tmp/pprof-token.txt)" https://localhost:6060/debug/pprof/ | head -30
<html>
<head>
<title>/debug/pprof/</title>
<style>
.profile-name{
	display:inline-block;
	width:6rem;
}
</style>
</head>
<body>
/debug/pprof/
<br>
<p>Set debug=1 as a query parameter to export in legacy text format</p>
<br>
Types of profiles available:
<table>
<thead><td>Count</td><td>Profile</td></thead>
<tr><td>170</td><td><a href='allocs?debug=1'>allocs</a></td></tr>
<tr><td>0</td><td><a href='block?debug=1'>block</a></td></tr>
<tr><td>0</td><td><a href='cmdline?debug=1'>cmdline</a></td></tr>
<tr><td>110</td><td><a href='goroutine?debug=1'>goroutine</a></td></tr>
<tr><td>170</td><td><a href='heap?debug=1'>heap</a></td></tr>
<tr><td>0</td><td><a href='mutex?debug=1'>mutex</a></td></tr>
<tr><td>0</td><td><a href='profile?debug=1'>profile</a></td></tr>
<tr><td>0</td><td><a href='symbol?debug=1'>symbol</a></td></tr>
<tr><td>11</td><td><a href='threadcreate?debug=1'>threadcreate</a></td></tr>
<tr><td>0</td><td><a href='trace?debug=1'>trace</a></td></tr>
</table>
<a href="goroutine?debug=2">full goroutine stack dump</a>

[openshift-ci-robot]

@perdasilva: This PR has been marked as verified by @perdasilva.

Details

In response to this:

/verified by @perdasilva

1. Scaled down CVO
2. Updated the machine-api-operator deployment adding the --enable-pprof flag to the pod template
3. Observed the pod being updated:

$ kubectl get pods -n openshift-machine-api machine-api-operator-967c47fcf-5rpct -o yaml | grep pprof
   - --enable-pprof

4. Observed machine-api-controller pod being updated:

$ kubectl get pods -n openshift-machine-api machine-api-controllers-d99668c59-57t5f -o yaml | grep pprof
   - --enable-pprof
   - --pprof-bind-address=127.0.0.1:6061
   name: kube-rbac-proxy-machine-pprof
     name: machine-pprof
   name: kube-rbac-proxy-machine-pprof

5. Setup port-forward to pprof endpoint using a metrics scrapper identity and setup port-forward

$ oc create token prometheus-k8s -n openshift-monitoring --duration=30m > /tmp/pprof-token.txt && echo "token length: $(wc -c </tmp/pprof-token.txt)"
token length: 1287

$ oc port-forward -n openshift-machine-api pod/machine-api-controllers-d99668c59-57t5f 6060:6060
Forwarding from 127.0.0.1:6060 -> 6060
Forwarding from [::1]:6060 -> 6060
Handling connection for 6060

6. curl to pprof endpoint

$ curl -sk -H "Authorization: Bearer $(cat /tmp/pprof-token.txt)" https://localhost:6060/debug/pprof/ | head -30
<html>
<head>
<title>/debug/pprof/</title>
<style>
.profile-name{
  display:inline-block;
  width:6rem;
}
</style>
</head>
<body>
/debug/pprof/
<br>
<p>Set debug=1 as a query parameter to export in legacy text format</p>
<br>
Types of profiles available:
<table>
<thead><td>Count</td><td>Profile</td></thead>
<tr><td>170</td><td><a href='allocs?debug=1'>allocs</a></td></tr>
<tr><td>0</td><td><a href='block?debug=1'>block</a></td></tr>
<tr><td>0</td><td><a href='cmdline?debug=1'>cmdline</a></td></tr>
<tr><td>110</td><td><a href='goroutine?debug=1'>goroutine</a></td></tr>
<tr><td>170</td><td><a href='heap?debug=1'>heap</a></td></tr>
<tr><td>0</td><td><a href='mutex?debug=1'>mutex</a></td></tr>
<tr><td>0</td><td><a href='profile?debug=1'>profile</a></td></tr>
<tr><td>0</td><td><a href='symbol?debug=1'>symbol</a></td></tr>
<tr><td>11</td><td><a href='threadcreate?debug=1'>threadcreate</a></td></tr>
<tr><td>0</td><td><a href='trace?debug=1'>trace</a></td></tr>
</table>
<a href="goroutine?debug=2">full goroutine stack dump</a>

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.