[release-4.22] SPLAT-2865: Added multi vCenter Day 2 Support by vr4manta · Pull Request #1531 · openshift/machine-api-operator

vr4manta · 2026-08-06T14:07:48Z

SPLAT-2865

Changes

Changed operator to load cloud config from openshift-config-managed
Added logic to add new VAP for validating infrastructure (FD) removals against current CPMS and machines
Created E2Es for new vSphere VAP

Notes:
This PR is backporting the following PRs in relation to the vSphere multi vCenter day 2 support feature:

…achines

…quickly

openshift-ci-robot · 2026-08-06T14:07:53Z

@vr4manta: This pull request references SPLAT-2865 which is a valid jira issue.

Details

In response to this:

SPLAT-2865

Changes

Added logic to add new VAP for validating infrastructure (FD) removals against current CPMS and machines

Created E2Es for new vSphere VAP

Notes:
This PR is backporting the following PRs in relation to the vSphere multi vCenter day 2 support feature:

SPLAT-2790: Added new VAP for vSphere infra validation against current cpms and machines #1510

SPLAT-2813: Create VAP E2Es #1517

SPLAT-2854: Fixing issue related to unintended VAP interactions #1518

SPLAT-2858: Fixing test issue where error result was for other resource type #1522

OCPBUGS-99903: Fixing test issue where error result was for other resource type #1524

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2026-08-06T14:07:53Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

coderabbitai · 2026-08-06T14:08:01Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 4de11b02-0192-4b50-9a17-7773bc2643ba

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

_{Comment @coderabbitai help to get the list of available commands.}

openshift-ci · 2026-08-06T19:04:45Z

@vr4manta: This PR was included in a payload test run from openshift/api#2969
trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

The Machine and MachineSet VAPs only checked whether a region/zone label pair existed in the incoming Infrastructure spec, so a Machine or MachineSet whose labels never matched any failure domain — old or new — caused every Infrastructure update to be denied. Add an oldFds variable sourced from oldObject and only deny when a failure domain existed in the old spec and was removed from the new one. (cherry picked from commit 4ef0ad1)

vr4manta · 2026-09-04T11:48:38Z

/pipeline required

openshift-merge-bot · 2026-09-04T11:48:42Z

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-operator
/test e2e-aws-ovn
/test e2e-aws-ovn-upgrade
/test e2e-metal-ipi
/test e2e-metal-ipi-ovn-ipv6
/test e2e-metal-ipi-virtualmedia

openshift-ci · 2026-09-04T11:59:54Z

@vr4manta: This PR was included in a payload test run from openshift/api#2969
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-main-nightly-4.22-e2e-vsphere-ovn-zones-techpreview-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/1d51e210-a858-11f1-8021-2ae6565127f3-0

openshift-ci · 2026-09-04T15:19:25Z

@vr4manta: This PR was included in a payload test run from openshift/api#2969
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-main-nightly-4.22-e2e-vsphere-ovn-zones-techpreview-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/fb9027b0-a873-11f1-9d70-57471176ae00-0

openshift-ci · 2026-09-08T11:30:58Z

@vr4manta: This PR was included in a payload test run from openshift/api#2969
trigger 2 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-main-nightly-4.22-e2e-vsphere-ovn-zones-techpreview-serial-1of2
periodic-ci-openshift-release-main-nightly-4.22-e2e-vsphere-ovn-zones-techpreview-serial-2of2

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/bb3dc9d0-ab78-11f1-89a9-861801216705-0

openshift-ci · 2026-09-08T13:14:18Z

@vr4manta: This PR was included in a payload test run from openshift/api#2969
trigger 2 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-main-nightly-4.22-e2e-vsphere-ovn-zones-techpreview-serial-1of2
periodic-ci-openshift-release-main-nightly-4.22-e2e-vsphere-ovn-zones-techpreview-serial-2of2

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/1248eda0-ab87-11f1-8f62-cd05816d43e3-0

openshift-ci · 2026-09-08T14:23:49Z

@vr4manta: This PR was included in a payload test run from openshift/api#2969
trigger 2 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-main-nightly-4.22-e2e-vsphere-ovn-zones-techpreview-serial-1of2
periodic-ci-openshift-release-main-nightly-4.22-e2e-vsphere-ovn-zones-techpreview-serial-2of2

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/c30f5bc0-ab90-11f1-99a2-f02f9eef2847-0

vr4manta · 2026-09-09T17:51:29Z

/retest

JoelSpeed · 2026-09-10T14:38:52Z

/label jira/valid-bug
/label backport-risk-assessed

vr4manta · 2026-09-10T16:15:55Z

/retest

damdo

/lgtm

openshift-merge-bot · 2026-09-11T11:43:32Z

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-operator
/test e2e-aws-ovn
/test e2e-aws-ovn-upgrade
/test e2e-metal-ipi
/test e2e-metal-ipi-ovn-ipv6

nrb · 2026-09-11T14:24:11Z

/approve

openshift-ci · 2026-09-11T14:27:47Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nrb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [nrb]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

vr4manta · 2026-09-14T14:30:20Z

/retest

damdo · 2026-09-15T13:56:50Z

Assessment: Run 2099509596598046720 does not provide evidence that this PR caused the failure. It failed in pre-test bare-metal provisioning/operator stability while waiting for clusteroperator/baremetal; no JUnit test records were produced.

PR changes vSphere/operator/VAP paths. The relevant helper is gated to VSpherePlatformType and FeatureGateVSphereMultiVCenterDay2; no bare-metal or virtualmedia files are changed. Similar pre-test timeouts have also appeared across other metal-ipi-virtualmedia jobs, which supports an infrastructure/provisioning issue rather than a regression in this PR.

/override ci/prow/e2e-metal-ipi-virtualmedia

openshift-ci · 2026-09-15T13:57:59Z

@damdo: Overrode contexts on behalf of damdo: ci/prow/e2e-metal-ipi-virtualmedia

Details

In response to this:

Assessment: Run 2099509596598046720 does not provide evidence that this PR caused the failure. It failed in pre-test bare-metal provisioning/operator stability while waiting for clusteroperator/baremetal; no JUnit test records were produced.

PR changes vSphere/operator/VAP paths. The relevant helper is gated to VSpherePlatformType and FeatureGateVSphereMultiVCenterDay2; no bare-metal or virtualmedia files are changed. Similar pre-test timeouts have also appeared across other metal-ipi-virtualmedia jobs, which supports an infrastructure/provisioning issue rather than a regression in this PR.

/override ci/prow/e2e-metal-ipi-virtualmedia

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

vr4manta · 2026-09-15T14:01:18Z

/verified by @vr4manta and /payload-job-with-prs : https://pr-payload-tests.ci.openshift.org/runs/ci/c30f5bc0-ab90-11f1-99a2-f02f9eef2847-0

openshift-ci-robot · 2026-09-15T14:01:30Z

@vr4manta: This PR has been marked as verified by @vr4manta and /payload-job-with-prs : https://pr-payload-tests.ci.openshift.org/runs/ci/c30f5bc0-ab90-11f1-99a2-f02f9eef2847-0.

Details

In response to this:

/verified by @vr4manta and /payload-job-with-prs : https://pr-payload-tests.ci.openshift.org/runs/ci/c30f5bc0-ab90-11f1-99a2-f02f9eef2847-0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2026-09-15T14:22:37Z

@vr4manta: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-metal-ipi-virtualmedia	`8fbe4e7`	link	true	`/test e2e-metal-ipi-virtualmedia`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

vr4manta added 6 commits August 6, 2026 09:54

Added new VAP for vSphere infra validation against current cpms and m…

3e12760

…achines

Created VAP e2e

2cebfd2

Fixing test issue where error result was for other resource type

9a7b4ac

Fixing issue related to unintended VAP interactions

cf5f768

Fixing test issue where error result was for other resource type

f00f7b4

Fixed issue where VAP did not reject due to attempting to delete too …

522dc2b

…quickly

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 6, 2026

openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 6, 2026

vr4manta mentioned this pull request Aug 6, 2026

[release-4.22] SPLAT-2865: Add vSphere multi vCenter Day 2 openshift/api#2969

Open

Changed vSphere cloud config to be read from openshift-config-managed

592b007

vr4manta changed the title ~~WIP: [release-4.22] SPLAT-2865: Added new VAP for vSphere infra validation against current cpms and machines~~ WIP: [release-4.22] SPLAT-2865: Added multi vCenter Day 2 Support Aug 10, 2026

vr4manta changed the title ~~WIP: [release-4.22] SPLAT-2865: Added multi vCenter Day 2 Support~~ [release-4.22] SPLAT-2865: Added multi vCenter Day 2 Support Sep 4, 2026

vr4manta marked this pull request as ready for review September 4, 2026 11:30

openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 4, 2026

openshift-ci Bot requested review from mdbooth and racheljpg September 4, 2026 11:30

openshift-ci Bot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. labels Sep 10, 2026

damdo reviewed Sep 11, 2026

View reviewed changes

openshift-ci Bot assigned damdo Sep 11, 2026

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 11, 2026

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 11, 2026

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Sep 15, 2026

openshift-merge-bot Bot merged commit 3fdcb56 into openshift:release-4.22 Sep 15, 2026
16 checks passed

Uh oh!

Conversation

vr4manta commented Aug 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Uh oh!

openshift-ci-robot commented Aug 6, 2026 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Uh oh!

openshift-ci Bot commented Aug 6, 2026

Uh oh!

coderabbitai Bot commented Aug 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

openshift-ci Bot commented Aug 6, 2026

Uh oh!

vr4manta commented Sep 4, 2026

Uh oh!

openshift-merge-bot Bot commented Sep 4, 2026

Uh oh!

openshift-ci Bot commented Sep 4, 2026

Uh oh!

openshift-ci Bot commented Sep 4, 2026

Uh oh!

openshift-ci Bot commented Sep 8, 2026

Uh oh!

openshift-ci Bot commented Sep 8, 2026

Uh oh!

openshift-ci Bot commented Sep 8, 2026

Uh oh!

vr4manta commented Sep 9, 2026

Uh oh!

JoelSpeed commented Sep 10, 2026

Uh oh!

vr4manta commented Sep 10, 2026

Uh oh!

damdo left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-merge-bot Bot commented Sep 11, 2026

Uh oh!

nrb commented Sep 11, 2026

Uh oh!

openshift-ci Bot commented Sep 11, 2026

Uh oh!

vr4manta commented Sep 14, 2026

Uh oh!

damdo commented Sep 15, 2026

Uh oh!

openshift-ci Bot commented Sep 15, 2026

Uh oh!

vr4manta commented Sep 15, 2026

Uh oh!

openshift-ci-robot commented Sep 15, 2026

Uh oh!

openshift-ci Bot commented Sep 15, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

vr4manta commented Aug 6, 2026 •

edited

Loading

openshift-ci-robot commented Aug 6, 2026 •

edited by openshift-ci Bot

Loading

coderabbitai Bot commented Aug 6, 2026 •

edited

Loading