OCPBUGS-90537: allow agent TUI to be shown also for rhcos10 base ISO#10640
OCPBUGS-90537: allow agent TUI to be shown also for rhcos10 base ISO#10640andfasano wants to merge 1 commit into
Conversation
(legacy framebuffer /dev/fb0 is no longer created)
openshift-ci-robot
added
jira/severity-important
|
@andfasano: This pull request references Jira Issue OCPBUGS-90537, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
📝 WalkthroughWalkthroughTwo systemd unit files for the agent interactive console are updated to add DRI card device gating. The serial variant adds ChangesAgent Console DRI Device Gating
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@andfasano: This pull request references Jira Issue OCPBUGS-90537, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@data/data/agent/systemd/units/agent-interactive-console.service`:
- Around line 1-8: The changes to the [Unit] section in the
agent-interactive-console.service file require regenerating the corresponding
systemd service diagrams. Run the make command for the agent diagrams directory
(specifically the docs/user/agent/diagrams make target) to regenerate the
diagrams that document the service dependencies and relationships, then commit
the updated diagram files to the PR to reflect the new configuration in the
agent-interactive-console.service unit.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: b2a830a0-f0dd-4b46-93e8-984778c794e5
📒 Files selected for processing (2)
data/data/agent/systemd/units/agent-interactive-console-serial@.servicedata/data/agent/systemd/units/agent-interactive-console.service
| [Unit] | ||
| Description=Get interactive user configuration at boot | ||
| After=dev-fb0.device network-pre.target NetworkManager.service pre-network-manager-config.service selinux.service agent-extract-tui.service set-hostname.service | ||
| After=dev-fb0.device dev-dri-card0.device network-pre.target NetworkManager.service pre-network-manager-config.service selinux.service agent-extract-tui.service set-hostname.service | ||
| Before=getty@tty1.service network.target network.service agent.service node-zero.service NetworkManager-wait-online.service agent-auth-token-status.service | ||
| Wants=agent-extract-tui.service | ||
| ConditionPathExists=/usr/local/bin/agent-tui | ||
| ConditionPathExists=/dev/fb0 | ||
| ConditionPathExists=|/dev/fb0 | ||
| ConditionPathExistsGlob=|/dev/dri/card* |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
# Check if the guidelines mention systemd diagram regeneration
grep -A 5 "systemd/units" AGENTS.md CLAUDE.md CONTRIBUTING.md README.md 2>/dev/null || echo "Not found in main docs"Repository: openshift/installer
Length of output: 86
🏁 Script executed:
# Verify the file location and check if docs/user/agent/diagrams exists
find . -type f -name "agent-interactive-console.service" 2>/dev/null
find . -type d -name "diagrams" 2>/dev/null | head -20Repository: openshift/installer
Length of output: 156
🏁 Script executed:
# Check if there's a Makefile in the agent diagrams directory
if [ -d "docs/user/agent/diagrams" ]; then
cat docs/user/agent/diagrams/Makefile 2>/dev/null || echo "No Makefile found"
else
echo "docs/user/agent/diagrams directory not found"
fiRepository: openshift/installer
Length of output: 1436
🏁 Script executed:
# Search for any systemd diagram regeneration guidance in the codebase
rg -i "systemd.*diagram|diagram.*systemd" --type markdown --type go 2>/dev/null | head -20Repository: openshift/installer
Length of output: 542
🏁 Script executed:
# Check the data/data/agent/systemd directory structure
ls -la data/data/agent/systemd/ 2>/dev/null || echo "Directory not accessible"Repository: openshift/installer
Length of output: 284
Regenerate agent systemd diagrams for this [Unit] change.
The systemd unit file changes affect the [Unit] section, which requires regenerating the agent service diagrams. Run make -C docs/user/agent/diagrams/ and include the updated diagrams in the PR.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@data/data/agent/systemd/units/agent-interactive-console.service` around lines
1 - 8, The changes to the [Unit] section in the
agent-interactive-console.service file require regenerating the corresponding
systemd service diagrams. Run the make command for the agent diagrams directory
(specifically the docs/user/agent/diagrams make target) to regenerate the
diagrams that document the service dependencies and relationships, then commit
the updated diagram files to the PR to reflect the new configuration in the
agent-interactive-console.service unit.
Source: Coding guidelines
|
@andfasano: This PR was included in a payload test run from openshift/appliance#721
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/fec81a90-6c01-11f1-982f-2f9795e1cf41-0 |
|
@andfasano: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
Required by openshift/appliance#721
Summary by CodeRabbit
Release Notes