SRVOCF-1071: Add deploy/undeploy button to list table actions - #181
Conversation
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
|
@Cragsmann: This pull request references SRVOCF-1071 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "5.1.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
165966f to
7ae60cd
Compare
Previously the functions list only offered a destructive delete that removed the Knative Service. Deploying a not-yet-deployed function required leaving the console entirely. Replace that with a single status-driven toggle in the Actions column: Deploy when the function is not running, Undeploy when it is. Backend: add a deploy endpoint that triggers the function's CI workflow via workflow_dispatch, add DispatchWorkflow to the SCM client, and emit the workflow_dispatch trigger in generated CI workflows so the dispatch has a target. Frontend: add a deployFunction client and drive the toggle button from function status, with inline success/error feedback. Deploy is guarded when the function has no source repository. Undeploy reuses the delete-modal flow but keeps the GitHub repository intact. Tests: record workflow_dispatch calls in the fake GitHub server and expose them for assertions, cover the deploy dispatch and the flip to Undeploy in e2e, and update unit and e2e expectations for the split buttons. The empty-state e2e is skipped outside CI, where a shared dev cluster usually has leftover functions. Issue SRVOCF-1071 Issue SRVOCF-1072 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
08cbdc5 to
88f2b0a
Compare
|
/test-e2e |
|
@Cragsmann: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/test e2e-aws |
Summary
workflow_dispatch, addDispatchWorkflowto the SCM client, and emit theworkflow_dispatchtrigger in generated CI workflows.deployFunctionclient and drive the toggle from function status with inline success/error feedback. Deploy is guarded when a function has no source repository; Undeploy reuses the delete-modal flow but keeps the GitHub repository intact.workflow_dispatchcalls in the fake GitHub server and expose them for assertions, cover the deploy dispatch and the flip to Undeploy in e2e, and update unit and e2e expectations for the split buttons. The empty-state e2e is skipped outside CI where a shared dev cluster usually has leftover functions.Fixes SRVOCF-1071
Relates to SRVOCF-1072
Checklist
docs/ARCHITECTURE.md(if there are relevant changes to our layered architecture)docs/TESTING.md(if there are relevant changes to our testing framework or setup)