SRVOCF-1074: Fix setup guide list number alignment in Firefox

[Cragsmann]

Summary

• 🐛 Fix ordered-list numbers rendering above (instead of beside) the step titles in the setup guide modal on Firefox. Root cause was PatternFly List/ListItem wrapping each block-level child in an inline <span>, which caused Firefox to misposition the ::marker inside the flex list. Switched to Content component="ol"/"li"/"p", which emits the markers directly in the <li> and aligns correctly in both Firefox and Chrome.
• 🔧 Style step titles with the pf-v6-u-font-weight-bold utility class instead of the <strong> element (CSS over markup).
• 🔧 Remove unused data-test attributes (setup-guide-button, setup-guide-modal, setup-guide-close-button) that are not referenced anywhere in the codebase or e2e specs.
• 🔧 Refactor SetupGuide to accept a className prop applied to its trigger button instead of wrapping the component in a <div> at the call site. In the empty state the link stays on its own centered line below the body text via pf-v6-u-display-block pf-v6-u-mx-auto pf-v6-u-mt-sm.
• 🔧 Add .claude/worktrees/ to .gitignore so local worktree scratch dirs do not pollute git status.

Fixes SRVOCF-1074

Checklist

• Updated docs/ARCHITECTURE.md (if there are relevant changes to our layered architecture)

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci-robot]

@Cragsmann: This pull request references SRVOCF-1074 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "5.1.0" version, but no target version was set.

Details

In response to this:

Summary

• 🐛 Fix ordered-list numbers rendering above (instead of beside) the step titles in the setup guide modal on Firefox. Root cause was PatternFly List/ListItem wrapping each block-level child in an inline <span>, which caused Firefox to misposition the ::marker inside the flex list. Switched to Content component="ol"/"li"/"p", which emits the markers directly in the <li> and aligns correctly in both Firefox and Chrome.
• 🔧 Style step titles with the pf-v6-u-font-weight-bold utility class instead of the <strong> element (CSS over markup).
• 🔧 Remove unused data-test attributes (setup-guide-button, setup-guide-modal, setup-guide-close-button) that are not referenced anywhere in the codebase or e2e specs.
• 🔧 Refactor SetupGuide to accept a className prop applied to its trigger button instead of wrapping the component in a <div> at the call site. In the empty state the link stays on its own centered line below the body text via pf-v6-u-display-block pf-v6-u-mx-auto pf-v6-u-mt-sm.
• 🔧 Add .claude/worktrees/ to .gitignore so local worktree scratch dirs do not pollute git status.

Fixes SRVOCF-1074

Checklist

• Updated docs/ARCHITECTURE.md (if there are relevant changes to our layered architecture)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[Cragsmann]

/retest

[twoGiants]

Looks good! Thank you 👍

Please inline the interface and we're good. I'll approve and hold. Let me know when to LGTM after that small change.

/approve
/lgtm
/hold for the interface inline fix

[openshift-merge-bot]

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: twoGiants

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [twoGiants]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[matejvasek]

Question of frontend n00b, aren't we supposed to use some imports instead of these string literals for classes:

e.g.

  import spacing from '@patternfly/react-styles/css/utilities/Spacing/spacing';
  import display from '@patternfly/react-styles/css/utilities/Display/display';
  import text from '@patternfly/react-styles/css/utilities/Text/text';
  import { css } from '@patternfly/react-styles';

  // EmptyState.tsx
  <SetupGuide className={css(display.displayBlock, spacing.mxAuto, spacing.mtSm)} />

  // SetupGuide.tsx
  <Content component="p" className={text.fontWeightBold}>
  <List component="ol" className={spacing.mtMd}>

[openshift-ci]

New changes are detected. LGTM label has been removed.

[openshift-ci]

@Cragsmann: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.