STOR-2997: Minimal implementation of GCP PD CSI driver operator by mpatlasov · Pull Request #576 · openshift/csi-operator

mpatlasov · 2026-07-08T01:58:09Z

This PR implements the minimal set of go-files and yaml-assets to enable the command

./bin/gcp-pd-csi-driver-smb-operator start --kubeconfig $KUBECONFIG --namespace openshift-cluster-csi-drivers

to install and run GCP PD CSI driver:

gcp-pd-csi-driver-controller-c949b748-xkljz   10/10   Running   0          3m2s
gcp-pd-csi-driver-controller-c949b748-xvgl9   10/10   Running   0          3m2s
gcp-pd-csi-driver-node-5kcw5                  3/3     Running   0          3m2s
gcp-pd-csi-driver-node-frl74                  3/3     Running   0          3m2s
gcp-pd-csi-driver-node-gf9k7                  3/3     Running   0          3m2s
gcp-pd-csi-driver-node-p95sv                  3/3     Running   0          3m2s
gcp-pd-csi-driver-node-q4r98                  3/3     Running   0          3m2s
gcp-pd-csi-driver-node-xvmgq                  3/3     Running   0          3m2s

/cc @openshift/storage

This PR implements the minimal set of go-files and yaml-assets to enable the command ``` ./bin/gcp-pd-csi-driver-smb-operator start --kubeconfig $KUBECONFIG --namespace openshift-cluster-csi-drivers ``` to install and run GCP PD CSI driver: ``` gcp-pd-csi-driver-controller-c949b748-xkljz 10/10 Running 0 3m2s gcp-pd-csi-driver-controller-c949b748-xvgl9 10/10 Running 0 3m2s gcp-pd-csi-driver-node-5kcw5 3/3 Running 0 3m2s gcp-pd-csi-driver-node-frl74 3/3 Running 0 3m2s gcp-pd-csi-driver-node-gf9k7 3/3 Running 0 3m2s gcp-pd-csi-driver-node-p95sv 3/3 Running 0 3m2s gcp-pd-csi-driver-node-q4r98 3/3 Running 0 3m2s gcp-pd-csi-driver-node-xvmgq 3/3 Running 0 3m2s ```

openshift-ci-robot · 2026-07-08T01:58:13Z

@mpatlasov: This pull request references STOR-2997 which is a valid jira issue.

Details

In response to this:

This PR implements the minimal set of go-files and yaml-assets to enable the command

./bin/gcp-pd-csi-driver-smb-operator start --kubeconfig $KUBECONFIG --namespace openshift-cluster-csi-drivers

to install and run GCP PD CSI driver:

gcp-pd-csi-driver-controller-c949b748-xkljz   10/10   Running   0          3m2s
gcp-pd-csi-driver-controller-c949b748-xvgl9   10/10   Running   0          3m2s
gcp-pd-csi-driver-node-5kcw5                  3/3     Running   0          3m2s
gcp-pd-csi-driver-node-frl74                  3/3     Running   0          3m2s
gcp-pd-csi-driver-node-gf9k7                  3/3     Running   0          3m2s
gcp-pd-csi-driver-node-p95sv                  3/3     Running   0          3m2s
gcp-pd-csi-driver-node-q4r98                  3/3     Running   0          3m2s
gcp-pd-csi-driver-node-xvmgq                  3/3     Running   0          3m2s

/cc @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2026-07-08T01:58:13Z

@mpatlasov: GitHub didn't allow me to request PR reviews from the following users: openshift/storage.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

This PR implements the minimal set of go-files and yaml-assets to enable the command

./bin/gcp-pd-csi-driver-smb-operator start --kubeconfig $KUBECONFIG --namespace openshift-cluster-csi-drivers

to install and run GCP PD CSI driver:

gcp-pd-csi-driver-controller-c949b748-xkljz   10/10   Running   0          3m2s
gcp-pd-csi-driver-controller-c949b748-xvgl9   10/10   Running   0          3m2s
gcp-pd-csi-driver-node-5kcw5                  3/3     Running   0          3m2s
gcp-pd-csi-driver-node-frl74                  3/3     Running   0          3m2s
gcp-pd-csi-driver-node-gf9k7                  3/3     Running   0          3m2s
gcp-pd-csi-driver-node-p95sv                  3/3     Running   0          3m2s
gcp-pd-csi-driver-node-q4r98                  3/3     Running   0          3m2s
gcp-pd-csi-driver-node-xvmgq                  3/3     Running   0          3m2s

/cc @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

coderabbitai · 2026-07-08T01:58:42Z

📝 Walkthrough

Walkthrough

This pull request adds a new CLI entrypoint for the GCP PD CSI Driver Operator at cmd/gcp-pd-csi-driver-operator/main.go, using Cobra to define a root command and a "start" subcommand wired via controllercmd.NewControllerCommandConfig. It also introduces pkg/driver/gcp-pd/gcp_pd.go, which provides GetGCPPDOperatorConfig for operator runtime configuration and GetGCPPDOperatorControllerConfig for controller configuration, including cluster flavour validation and starting client config informers.

Changes

Cohort / File(s)	Summary
GCP PD operator bootstrap: `cmd/gcp-pd-csi-driver-operator/main.go`, `pkg/driver/gcp-pd/gcp_pd.go`	Adds CLI entrypoint with Cobra root/start commands and `runCSIDriverOperator` handler; adds `GetGCPPDOperatorConfig` and `GetGCPPDOperatorControllerConfig` for operator/controller configuration with cluster flavour validation

Sequence Diagram(s)

sequenceDiagram
  participant main
  participant NewOperatorCommand
  participant runCSIDriverOperator
  participant GetGCPPDOperatorConfig
  participant RunOperator

  main->>NewOperatorCommand: build CLI command
  NewOperatorCommand->>runCSIDriverOperator: execute start subcommand
  runCSIDriverOperator->>GetGCPPDOperatorConfig: fetch operator config
  runCSIDriverOperator->>RunOperator: run with controller context

Related issues: None specified.

Related PRs: None specified.

Suggested labels: enhancement, gcp-pd, new-driver

Suggested reviewers: None specified.

Poem:
A rabbit hops to GCP's disk,
A new command, crisp and brisk.
Cobra roots and subcommands spun,
The PD operator's job's begun.
With flavours checked and configs set,
Another driver's entrypoint met. 🐇💾

Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (2 errors)

Check name	Status	Explanation	Resolution
Ote Binary Stdout Contract	❌ Error	cmd/gcp-pd-csi-driver-operator/main.go calls cmd.Help() in the root Run path, which writes help text to stdout with no stderr redirection.	Send help output to stderr or avoid printing from the root Run path (e.g. set cmd.Out/Err to os.Stderr before Help(), or use an error return).
Container-Privileges	❌ Error	New GCP-PD manifests add hostNetwork:true and privileged:true in pod specs, which this check forbids.	Remove or justify hostNetwork/privileged securityContext settings in the new GCP-PD controller/node manifests, and align SCCs accordingly.

✅ Passed checks (13 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly matches the main change: a minimal implementation of the GCP PD CSI driver operator.
Description check	✅ Passed	The description is directly related to the changeset and explains the operator command and resulting driver deployment.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The PR only touches non-test Go files, and no Ginkgo-style test declarations or *_test.go files appear under the changed paths.
Test Structure And Quality	✅ Passed	No Ginkgo/Gomega test files were added or modified in this PR, so the test-structure checklist is not applicable.
Microshift Test Compatibility	✅ Passed	No new Ginkgo e2e tests were added; the diff only adds operator entrypoints and YAML assets, with no *_test.go files or Ginkgo APIs.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	No new Ginkgo specs or *_test.go files were added; the diff only changes operator code and generated manifests, so SNO test compatibility is not implicated.
Topology-Aware Scheduling Compatibility	✅ Passed	PASS: The new GCP-PD controller uses the standard master selector, only preferred anti-affinity, and maxUnavailable: 1; the operator is standalone-only, so no topology deadlock/HyperShift trap.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	No new Ginkgo/e2e tests were added; the PR only adds operator entrypoint/config files and no IPv4 or external-network test code.
No-Weak-Crypto	✅ Passed	The new Go files only wire CLI/operator config; no weak crypto APIs, custom crypto, or secret/token comparisons were added.
No-Sensitive-Data-In-Logs	✅ Passed	The only new log line is a generic unsupported-flavour error; no passwords, tokens, PII, hostnames, or customer data are logged.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Comment @coderabbitai help to get the list of available commands.}

openshift-ci · 2026-07-08T01:58:45Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mpatlasov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [mpatlasov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

coderabbitai

🧹 Nitpick comments (2)

pkg/driver/gcp-pd/gcp_pd.go (1)
36-39: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Fix malformed log call and redundant/non-idiomatic error message.

klog.Error(nil, "...") treats nil as a fmt.Print-style argument (klog's Error args are "handled in the manner of fmt.Print"), so this prints something like <nil>Flavour HyperShift is not supported! instead of a clean message. Additionally, this error is already logged again by the caller (RunOperator logs "error building operator config: %v" on any non-nil error from this builder), so the local klog.Error call is redundant. The fmt.Errorf message is also capitalized and ends with !, which violates Go's error-string convention (lower-case, no trailing punctuation).
🔧 Proposed fix
 	if flavour != generator.FlavourStandalone {
-		klog.Error(nil, "Flavour HyperShift is not supported!")
-		return nil, fmt.Errorf("Flavour HyperShift is not supported!")
+		return nil, fmt.Errorf("flavour %q is not supported", flavour)
 	}
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@pkg/driver/gcp-pd/gcp_pd.go` around lines 36 - 39, The gcp_pd builder’s
unsupported-flavour branch is logging incorrectly and returning a non-idiomatic
error. In the config builder path in `gcp_pd.go`, remove the local
`klog.Error(nil, ...)` call because `RunOperator` already logs builder failures,
and change the returned `fmt.Errorf` message to a lowercase, punctuation-free
error string. Keep the check on `flavour != generator.FlavourStandalone` and
ensure the branch only returns the clean error.
cmd/gcp-pd-csi-driver-operator/main.go (1)
27-30: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value

Ignored error return from cmd.Help().

cmd.Help() returns an error that's discarded here.
🔧 Proposed fix
 		Run: func(cmd *cobra.Command, args []string) {
-			cmd.Help()
+			if err := cmd.Help(); err != nil {
+				klog.Errorf("failed to print help: %v", err)
+			}
 			os.Exit(1)
 		},
As per path instructions, "Never ignore error returns" for **/*.go.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@cmd/gcp-pd-csi-driver-operator/main.go` around lines 27 - 30, The cobra
command’s Run handler is discarding the error from cmd.Help(), which violates
the “never ignore error returns” rule. Update the Run function in main.go to
check and handle the return value from cmd.Help() explicitly, using the
cmd.Help() call itself as the unique locator, and ensure the process still exits
with a non-zero status if Help fails.
Source: Path instructions

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@cmd/gcp-pd-csi-driver-operator/main.go`:
- Around line 27-30: The cobra command’s Run handler is discarding the error
from cmd.Help(), which violates the “never ignore error returns” rule. Update
the Run function in main.go to check and handle the return value from cmd.Help()
explicitly, using the cmd.Help() call itself as the unique locator, and ensure
the process still exits with a non-zero status if Help fails.

In `@pkg/driver/gcp-pd/gcp_pd.go`:
- Around line 36-39: The gcp_pd builder’s unsupported-flavour branch is logging
incorrectly and returning a non-idiomatic error. In the config builder path in
`gcp_pd.go`, remove the local `klog.Error(nil, ...)` call because `RunOperator`
already logs builder failures, and change the returned `fmt.Errorf` message to a
lowercase, punctuation-free error string. Keep the check on `flavour !=
generator.FlavourStandalone` and ensure the branch only returns the clean error.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 51202570-b405-4a12-9cee-b72111c8a207

📥 Commits

Reviewing files that changed from the base of the PR and between 1c2b08b and 5ed0670.

⛔ Files ignored due to path filters (30)

assets/overlays/gcp-pd/generated/standalone/cabundle_cm.yaml is excluded by !**/generated/**
assets/overlays/gcp-pd/generated/standalone/controller.yaml is excluded by !**/generated/**
assets/overlays/gcp-pd/generated/standalone/controller_pdb.yaml is excluded by !**/generated/**
assets/overlays/gcp-pd/generated/standalone/controller_sa.yaml is excluded by !**/generated/**
assets/overlays/gcp-pd/generated/standalone/csidriver.yaml is excluded by !**/generated/**
assets/overlays/gcp-pd/generated/standalone/kube_rbac_proxy_binding.yaml is excluded by !**/generated/**
assets/overlays/gcp-pd/generated/standalone/kube_rbac_proxy_role.yaml is excluded by !**/generated/**
assets/overlays/gcp-pd/generated/standalone/lease_leader_election_role.yaml is excluded by !**/generated/**
assets/overlays/gcp-pd/generated/standalone/lease_leader_election_rolebinding.yaml is excluded by !**/generated/**
assets/overlays/gcp-pd/generated/standalone/main_attacher_binding.yaml is excluded by !**/generated/**
assets/overlays/gcp-pd/generated/standalone/main_provisioner_binding.yaml is excluded by !**/generated/**
assets/overlays/gcp-pd/generated/standalone/main_resizer_binding.yaml is excluded by !**/generated/**
assets/overlays/gcp-pd/generated/standalone/main_snapshotter_binding.yaml is excluded by !**/generated/**
assets/overlays/gcp-pd/generated/standalone/manifests.yaml is excluded by !**/generated/**
assets/overlays/gcp-pd/generated/standalone/node.yaml is excluded by !**/generated/**
assets/overlays/gcp-pd/generated/standalone/node_privileged_binding.yaml is excluded by !**/generated/**
assets/overlays/gcp-pd/generated/standalone/node_sa.yaml is excluded by !**/generated/**
assets/overlays/gcp-pd/generated/standalone/privileged_role.yaml is excluded by !**/generated/**
assets/overlays/gcp-pd/generated/standalone/prometheus_role.yaml is excluded by !**/generated/**
assets/overlays/gcp-pd/generated/standalone/prometheus_rolebinding.yaml is excluded by !**/generated/**
assets/overlays/gcp-pd/generated/standalone/service.yaml is excluded by !**/generated/**
assets/overlays/gcp-pd/generated/standalone/servicemonitor.yaml is excluded by !**/generated/**
assets/overlays/gcp-pd/generated/standalone/storageclass.yaml is excluded by !**/generated/**
assets/overlays/gcp-pd/generated/standalone/storageclass_reader_resizer_binding.yaml is excluded by !**/generated/**
assets/overlays/gcp-pd/generated/standalone/storageclass_ssd.yaml is excluded by !**/generated/**
assets/overlays/gcp-pd/generated/standalone/volumeattributesclass_reader_provisioner_binding.yaml is excluded by !**/generated/**
assets/overlays/gcp-pd/generated/standalone/volumeattributesclass_reader_resizer_binding.yaml is excluded by !**/generated/**
assets/overlays/gcp-pd/generated/standalone/volumesnapshot_reader_provisioner_binding.yaml is excluded by !**/generated/**
assets/overlays/gcp-pd/generated/standalone/volumesnapshotclass.yaml is excluded by !**/generated/**
assets/overlays/gcp-pd/generated/standalone/volumesnapshotclass_images.yaml is excluded by !**/generated/**

📒 Files selected for processing (2)

cmd/gcp-pd-csi-driver-operator/main.go
pkg/driver/gcp-pd/gcp_pd.go

mpatlasov · 2026-07-08T14:26:52Z

/retest

mpatlasov · 2026-07-08T23:17:45Z

/retest-required

mpatlasov · 2026-07-09T14:40:20Z

/retest-required

openshift-ci · 2026-07-09T18:28:28Z

@mpatlasov: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/hypershift-e2e-aks	`5ed0670`	link	false	`/test hypershift-e2e-aks`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

mpatlasov · 2026-07-09T19:08:43Z

/retest-required

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 8, 2026

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 8, 2026

coderabbitai Bot reviewed Jul 8, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

STOR-2997: Minimal implementation of GCP PD CSI driver operator#576

STOR-2997: Minimal implementation of GCP PD CSI driver operator#576
mpatlasov wants to merge 1 commit into
openshift:mainfrom
mpatlasov:STOR-2997-Implement-GCP-PD-CSI-driver-operator-inside-csi-operator-framework

mpatlasov commented Jul 8, 2026

Uh oh!

openshift-ci-robot commented Jul 8, 2026 •

edited by openshift-ci Bot

Loading

Uh oh!

openshift-ci Bot commented Jul 8, 2026

Uh oh!

coderabbitai Bot commented Jul 8, 2026 •

edited

Loading

Walkthrough

Changes

Sequence Diagram(s)

Pre-merge checks failed

Uh oh!

openshift-ci Bot commented Jul 8, 2026

Uh oh!

coderabbitai Bot left a comment

Uh oh!

mpatlasov commented Jul 8, 2026

Uh oh!

mpatlasov commented Jul 8, 2026

Uh oh!

mpatlasov commented Jul 9, 2026

Uh oh!

openshift-ci Bot commented Jul 9, 2026 •

edited

Loading

Uh oh!

mpatlasov commented Jul 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

mpatlasov commented Jul 8, 2026

Uh oh!

openshift-ci-robot commented Jul 8, 2026 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci Bot commented Jul 8, 2026

Uh oh!

coderabbitai Bot commented Jul 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Pre-merge checks failed

❌ Failed checks (2 errors)

Uh oh!

openshift-ci Bot commented Jul 8, 2026

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

mpatlasov commented Jul 8, 2026

Uh oh!

mpatlasov commented Jul 8, 2026

Uh oh!

mpatlasov commented Jul 9, 2026

Uh oh!

openshift-ci Bot commented Jul 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mpatlasov commented Jul 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

openshift-ci-robot commented Jul 8, 2026 •

edited by openshift-ci Bot

Loading

coderabbitai Bot commented Jul 8, 2026 •

edited

Loading

openshift-ci Bot commented Jul 9, 2026 •

edited

Loading