Skip to content

OCPBUGS-112263: Allow free-form group entry in impersonation modal #17063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
platex-rehor-bot wants to merge 4 commits into
base: main
Choose a base branch
from
Open

OCPBUGS-112263: Allow free-form group entry in impersonation modal #17063

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d0cc20c
fix(impersonate): allow free-form group entry when Group model is absent
platex-rehor-bot Aug 20, 2026
5543b49
fix(impersonate): add groups-help-text id and fix model-absent test m…
platex-rehor-bot Aug 20, 2026
4e77b29
chore(i18n): update translation strings for group impersonation
platex-rehor-bot Aug 20, 2026
96ff2dc
OCPBUGS-112263: Fix react-compiler lint warnings in impersonate modal
platex-rehor-bot Aug 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
71 changes: 62 additions & 9 deletions frontend/public/components/modals/__tests__/impersonate-user-modal-integration.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,7 @@ describe('ImpersonateUserModal Integration Tests', () => {
});
});

it('should show no results when filter matches nothing', async () => {
it('should show "Create" option when filter matches nothing in available groups', async () => {
const user = userEvent.setup();
render(
<Provider store={mockStore}>
Expand All @@ -268,31 +268,84 @@ describe('ImpersonateUserModal Integration Tests', () => {
// Type to filter with non-matching text
await user.type(groupsInput, 'nonexistent');

expect(await screen.findByText('No results found')).toBeVisible();
// Should show "Create" option instead of just "No results found"
expect(await screen.findByText('Create "nonexistent"')).toBeVisible();
});
});

describe('Error handling workflow', () => {
it('should show error when groups fail to load', async () => {
const error = new Error('Failed to fetch groups');
(useK8sWatchResource as jest.Mock).mockReturnValue([[], false, error]);
describe('Direct Authentication / model-absent workflow', () => {
it('should allow group impersonation when Group model does not exist', async () => {
const error = new Error('Model does not exist');
(useK8sWatchResource as jest.Mock).mockReturnValue([[], true, error]);

const user = userEvent.setup();
const onImpersonate = jest.fn();

render(
<Provider store={mockStore}>
<ImpersonateUserModal isOpen onClose={jest.fn()} onImpersonate={jest.fn()} />
<ImpersonateUserModal isOpen onClose={jest.fn()} onImpersonate={onImpersonate} />
</Provider>,
);

expect(await screen.findByText('Failed to load groups')).toBeVisible();
// Should NOT show error alert
expect(screen.queryByText('Failed to load groups')).not.toBeInTheDocument();

// Should show helper text for manual entry
expect(
screen.getByText('Type group names manually. Press Enter to add each group.'),
).toBeInTheDocument();

// Enter username
const usernameInput = screen.getByTestId('username-input');
await user.clear(usernameInput);
await user.type(usernameInput, 'oidc-user');

// Enter groups via free-form
const groupInput = screen.getByPlaceholderText('Enter groups');
await user.click(groupInput);
await user.type(groupInput, 'oidc-admins{Enter}');
await user.type(groupInput, 'oidc-devs{Enter}');

// Both groups should appear as chips
await waitFor(() => {
expect(screen.getByText('oidc-admins')).toBeInTheDocument();
expect(screen.getByText('oidc-devs')).toBeInTheDocument();
});

// Submit
const submitButton = screen.getByTestId('impersonate-button');
await user.click(submitButton);

await waitFor(() => {
expect(onImpersonate).toHaveBeenCalledWith('oidc-user', ['oidc-admins', 'oidc-devs']);
});
});

it('should still allow impersonation without groups when model is absent', async () => {
const error = new Error('Model does not exist');
(useK8sWatchResource as jest.Mock).mockReturnValue([[], true, error]);

// Should still allow impersonation without groups
const ue = userEvent.setup();
const onImpersonate = jest.fn();

render(
<Provider store={mockStore}>
<ImpersonateUserModal isOpen onClose={jest.fn()} onImpersonate={onImpersonate} />
</Provider>,
);

const usernameInput = screen.getByTestId('username-input');
await ue.clear(usernameInput);
await ue.type(usernameInput, 'erroruser');

const submitButton = screen.getByTestId('impersonate-button');
expect(submitButton).not.toBeDisabled();

await ue.click(submitButton);

await waitFor(() => {
expect(onImpersonate).toHaveBeenCalledWith('erroruser', []);
});
});
});

Expand Down
157 changes: 152 additions & 5 deletions frontend/public/components/modals/__tests__/impersonate-user-modal.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,17 +163,164 @@ describe('ImpersonateUserModal', () => {
expect(screen.getByPlaceholderText('Enter groups')).toBeInTheDocument();
});

it('should show error alert when groups fail to load', () => {
const error = new Error('Failed to load groups');
it('should gracefully handle group load errors without showing error alert', () => {
const error = new Error('Model does not exist');
(useK8sWatchResource as jest.Mock).mockReturnValue([[], false, error]);

render(
<ImpersonateUserModal isOpen onClose={mockOnClose} onImpersonate={mockOnImpersonate} />,
);

// Check for alert with danger variant
const alerts = screen.getAllByText('Failed to load groups');
expect(alerts.length).toBeGreaterThan(0);
// Should NOT show error alert — free-form entry is available instead
expect(screen.queryByText('Failed to load groups')).not.toBeInTheDocument();
// Should show helper text for manual entry
expect(
screen.getByText('Type group names manually. Press Enter to add each group.'),
).toBeInTheDocument();
});
});

describe('Free-form Group Entry', () => {
it('should add a group on Enter key press', async () => {
const user = userEvent.setup();
// Groups model unavailable
const error = new Error('Model does not exist');
(useK8sWatchResource as jest.Mock).mockReturnValue([[], true, error]);

render(
<ImpersonateUserModal isOpen onClose={mockOnClose} onImpersonate={mockOnImpersonate} />,
);

const groupInput = screen.getByPlaceholderText('Enter groups');
await user.click(groupInput);
await user.type(groupInput, 'my-custom-group{Enter}');

// Group chip should appear
await waitFor(() => {
expect(screen.getByText('my-custom-group')).toBeInTheDocument();
});
});

it('should add multiple free-form groups', async () => {
const user = userEvent.setup();
const error = new Error('Model does not exist');
(useK8sWatchResource as jest.Mock).mockReturnValue([[], true, error]);

render(
<ImpersonateUserModal isOpen onClose={mockOnClose} onImpersonate={mockOnImpersonate} />,
);

const groupInput = screen.getByPlaceholderText('Enter groups');
await user.click(groupInput);
await user.type(groupInput, 'group-a{Enter}');
await user.type(groupInput, 'group-b{Enter}');

await waitFor(() => {
expect(screen.getByText('group-a')).toBeInTheDocument();
expect(screen.getByText('group-b')).toBeInTheDocument();
});
});

it('should not add duplicate groups on Enter', async () => {
const user = userEvent.setup();
const error = new Error('Model does not exist');
(useK8sWatchResource as jest.Mock).mockReturnValue([[], true, error]);

render(
<ImpersonateUserModal isOpen onClose={mockOnClose} onImpersonate={mockOnImpersonate} />,
);

const groupInput = screen.getByPlaceholderText('Enter groups');
await user.click(groupInput);
await user.type(groupInput, 'my-group{Enter}');
await user.type(groupInput, 'my-group{Enter}');

await waitFor(() => {
// eslint-disable-next-line testing-library/no-node-access -- checking chip count
const chips = document.querySelectorAll('.pf-v6-c-label');
expect(chips.length).toBe(1);
});
});

it('should show "Create" option in dropdown for new group name', async () => {
const user = userEvent.setup();
render(
<ImpersonateUserModal isOpen onClose={mockOnClose} onImpersonate={mockOnImpersonate} />,
);

const groupInput = screen.getByPlaceholderText('Enter groups');
await user.click(groupInput);
await user.type(groupInput, 'new-custom-group');

await waitFor(() => {
expect(screen.getByText('Create "new-custom-group"')).toBeInTheDocument();
});
});

it('should add group via "Create" option click', async () => {
const user = userEvent.setup();
render(
<ImpersonateUserModal isOpen onClose={mockOnClose} onImpersonate={mockOnImpersonate} />,
);

const groupInput = screen.getByPlaceholderText('Enter groups');
await user.click(groupInput);
await user.type(groupInput, 'new-custom-group');

const createOption = await screen.findByTestId('create-group-option');
await user.click(createOption);

await waitFor(() => {
// eslint-disable-next-line testing-library/no-node-access -- checking chip appearance
const chips = document.querySelectorAll('.pf-v6-c-label');
expect(chips.length).toBe(1);
});
});

it('should submit free-form groups with onImpersonate', async () => {
const user = userEvent.setup();
const error = new Error('Model does not exist');
(useK8sWatchResource as jest.Mock).mockReturnValue([[], true, error]);

render(
<ImpersonateUserModal isOpen onClose={mockOnClose} onImpersonate={mockOnImpersonate} />,
);

const usernameInput = screen.getByTestId('username-input');
await user.clear(usernameInput);
await user.type(usernameInput, 'testuser');

const groupInput = screen.getByPlaceholderText('Enter groups');
await user.click(groupInput);
await user.type(groupInput, 'oidc-admins{Enter}');
await user.type(groupInput, 'oidc-developers{Enter}');

const submitButton = screen.getByTestId('impersonate-button');
await user.click(submitButton);

await waitFor(() => {
expect(mockOnImpersonate).toHaveBeenCalledWith('testuser', [
'oidc-admins',
'oidc-developers',
]);
});
});

it('should show hint text when model unavailable and no text typed', async () => {
const user = userEvent.setup();
const error = new Error('Model does not exist');
(useK8sWatchResource as jest.Mock).mockReturnValue([[], true, error]);

render(
<ImpersonateUserModal isOpen onClose={mockOnClose} onImpersonate={mockOnImpersonate} />,
);

const groupInput = screen.getByPlaceholderText('Enter groups');
await user.click(groupInput);

await waitFor(() => {
expect(screen.getByText('Type a group name and press Enter')).toBeInTheDocument();
});
});
});

Expand Down
Loading