OCPBUGS-87505: Updating ose-cloud-credential-operator-container image to be consistent with ART for 5.0#1037
Conversation
|
Created by ART pipeline job run https://art-jenkins.apps.prod-stable-spoke1-dc-iad2.itup.redhat.com/job/aos-cd-builds/job/build%252Fsync-ci-images/216 |
openshift-bot
changed the title
WalkthroughCI operator and Docker build infrastructure upgraded from Go 1.25 / OpenShift 4.22 to Go 1.26 / OpenShift 5.0. RHEL9 builder and runtime images updated. RHEL8 builder refactored to compile only ChangesBuild Infrastructure Upgrade to Go 1.26 and OpenShift 5.0
🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
openshift-ci-robot
added
jira/valid-reference
|
@openshift-bot: This pull request references Jira Issue OCPBUGS-87505, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@openshift-bot: This pull request references Jira Issue OCPBUGS-87505, which is valid. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
Dockerfile (1)
19-36: 🛠️ Refactor suggestion | 🟠 Major | ⚡ Quick winAdd USER directive to run as non-root.
The Dockerfile violates container security guidelines by not specifying a non-root user. The container will run as root, which increases the attack surface and violates the principle of least privilege.
As per coding guidelines, container images must specify
USER non-rootand never run as root. The static analysis tool (Trivy DS-0002) also flagged this violation.🔒 Proposed fix to add non-root user
Add a USER directive before the ENTRYPOINT to run as a non-root user. OpenShift base images typically support arbitrary user IDs in the range 1000-65534:
RUN chmod -R g+w /etc/pki/ca-trust/extracted/pem/ +USER 1001 LABEL io.openshift.release.operator=true🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@Dockerfile` around lines 19 - 36, The Dockerfile runs as root (no USER) so add a non-root user directive (e.g., USER 1000) before the ENTRYPOINT to comply with least-privilege rules; ensure any files/dirs the process needs are readable/writable by that UID by adjusting ownership or permissions (for example, change ownership of /usr/bin/cloud-credential-operator, /manifests and /etc/pki/ca-trust/extracted/pem/ as needed) — update the existing RUN chmod -R g+w /etc/pki/ca-trust/extracted/pem/ line or add RUN chown -R 1000:0 <paths> so the non-root UID can access them, then place USER 1000 immediately prior to ENTRYPOINT [ "/usr/bin/cloud-credential-operator" ].Sources: Coding guidelines, Linters/SAST tools
🧹 Nitpick comments (1)
Dockerfile (1)
19-36: ⚡ Quick winAdd HEALTHCHECK directive for container health monitoring.
The Dockerfile is missing a HEALTHCHECK directive, which is required per container security guidelines. Without it, orchestrators cannot verify whether the container is healthy or needs to be restarted.
🏥 Proposed fix to add health check
Add a HEALTHCHECK directive appropriate for the operator. If the operator exposes a health endpoint, use that; otherwise, a simple process check:
COPY manifests /manifests +HEALTHCHECK --interval=30s --timeout=3s --start-period=10s --retries=3 \ + CMD ps aux | grep -v grep | grep -q cloud-credential-operator || exit 1 + # Update perms so we can copy updated CA if needed RUN chmod -R g+w /etc/pki/ca-trust/extracted/pem/Note: If the operator exposes a
/healthzor/readyzendpoint, prefer an HTTP health check instead.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@Dockerfile` around lines 19 - 36, The Dockerfile lacks a HEALTHCHECK which prevents runtime health monitoring; add a HEALTHCHECK directive near the end (after COPY/LABEL/ENTRYPOINT) that probes the operator process launched by ENTRYPOINT (/usr/bin/cloud-credential-operator): prefer an HTTP probe to the operator's /healthz or /readyz endpoint if available (use curl/wget against localhost and appropriate port), otherwise use a lightweight process check (e.g., verify the cloud-credential-operator binary is running via pid or pgrep) and configure sensible interval/retries/start-period values so orchestrators can detect and restart unhealthy containers.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@Dockerfile`:
- Around line 19-36: The Dockerfile runs as root (no USER) so add a non-root
user directive (e.g., USER 1000) before the ENTRYPOINT to comply with
least-privilege rules; ensure any files/dirs the process needs are
readable/writable by that UID by adjusting ownership or permissions (for
example, change ownership of /usr/bin/cloud-credential-operator, /manifests and
/etc/pki/ca-trust/extracted/pem/ as needed) — update the existing RUN chmod -R
g+w /etc/pki/ca-trust/extracted/pem/ line or add RUN chown -R 1000:0 <paths> so
the non-root UID can access them, then place USER 1000 immediately prior to
ENTRYPOINT [ "/usr/bin/cloud-credential-operator" ].
---
Nitpick comments:
In `@Dockerfile`:
- Around line 19-36: The Dockerfile lacks a HEALTHCHECK which prevents runtime
health monitoring; add a HEALTHCHECK directive near the end (after
COPY/LABEL/ENTRYPOINT) that probes the operator process launched by ENTRYPOINT
(/usr/bin/cloud-credential-operator): prefer an HTTP probe to the operator's
/healthz or /readyz endpoint if available (use curl/wget against localhost and
appropriate port), otherwise use a lightweight process check (e.g., verify the
cloud-credential-operator binary is running via pid or pgrep) and configure
sensible interval/retries/start-period values so orchestrators can detect and
restart unhealthy containers.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 8728c5ad-d169-49a7-8646-8921f0b9dcc8
📒 Files selected for processing (2)
.ci-operator.yamlDockerfile
|
ART wants to connect issue OCPBUGS-87758 to this PR, but found it is currently hooked up to ['OCPBUGS-87505']. Please consult with #forum-ocp-art if it is not clear what there is to do. |
openshift-bot
added
the
verified
|
/test security |
|
/lgtm |
|
@dlom can you approve this? |
|
/retest |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dlom, openshift-bot, tmshort The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
/retest |
|
/override ci/prow/security |
|
@dlom: Overrode contexts on behalf of dlom: ci/prow/security DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@openshift-bot: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@openshift-bot: Jira Issue Verification Checks: Jira Issue OCPBUGS-87505 Jira Issue OCPBUGS-87505 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
4 participants
Updating ose-cloud-credential-operator-container image to be consistent with ART for 5.0
TLDR:
Product builds by ART can be configured for different base and builder images than corresponding CI
builds. This automated PR requests a change to CI configuration to align with ART's configuration;
please take steps to merge it quickly or contact ART to coordinate changes.
The configuration in the following ART component metadata is driving this alignment request:
ose-cloud-credential-operator.yml.
Detail:
This repository is out of sync with the downstream product builds for this component. The CI
configuration for at least one image differs from ART's expected product configuration. This should
be addressed to ensure that the component's CI testing accurate reflects what customers will
experience.
Most of these PRs are opened as an ART-driven proposal to migrate base image or builder(s) to a
different version, usually prior to GA. The intent is to effect changes in both configurations
simultaneously without breaking either CI or ART builds, so usually ART builds are configured to
consider CI as canonical and attempt to match CI config until the PR merges to align both. ART may
also configure changes in GA releases with CI remaining canonical for a brief grace period to enable
CI to succeed and the alignment PR to merge. In either case, ART configuration will be made
canonical at some point (typically at branch-cut before GA or release dev-cut after GA), so it is
important to align CI configuration as soon as possible.
PRs are also triggered when CI configuration changes without ART coordination, for instance to
change the number of builder images or to use a different golang version. These changes should be
coordinated with ART; whether ART configuration is canonical or not, preferably it would be updated
first to enable the changes to occur simultaneously in both CI and ART at the same time. This also
gives ART a chance to validate the intended changes first. For instance, ART compiles most
components with the Golang version being used by the control plane for a given OpenShift release.
Exceptions to this convention (i.e. you believe your component must be compiled with a Golang
version independent from the control plane) must be granted by the OpenShift staff engineers and
communicated to the ART team.
Roles & Responsibilities:
tests OR that necessary metadata changes are reported to the ART team
in
#forum-ocp-arton Slack. If necessary, the changes required by this pull request can beintroduced with a separate PR opened by the component team. Once the repository is aligned,
this PR will be closed automatically.
verify-depsis complaining. In that case, please opena new PR with the dependency issues addressed (and base images bumped). ART-9595 for reference.
any required labels to ensure the PR merges once tests are passing. In cases where ART config is
canonical, downstream builds are already being built with these changes, and merging this PR
only improves the fidelity of our CI. In cases where ART config is not canonical, this provides
a grace period for the component team to align their CI with ART's configuration before it becomes
canonical in product builds.
ART has been configured to reconcile your CI build root image (see https://docs.ci.openshift.org/docs/architecture/ci-operator/#build-root-image).
In order for your upstream .ci-operator.yaml configuration to be honored, you must set the following in your openshift/release ci-operator configuration file:
Change behavior of future PRs:
set up automatically. This means that such a PR would merge without human intervention (and awareness!) in the future.
To do so, open a PR to set the
auto_labelattribute in the image configuration. ExampleUPSTREAM: <carry>:. An example.If you have any questions about this pull request, please reach out in the
#forum-ocp-artSlack channel.