Add JUnit 4 where the PowerMock JUnit 4 module provided it - #1151
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
RemovePowerMockDependenciesnow first runs a newAddJUnit4ReplacingPowerMockModule, which addsjunit:junit:4.13.2(test scope /testImplementation) to modules that:powermock-module-junit4*, which brings JUnit 4 in transitively;org.junit.*types;Why
In the corpus of open source PowerMock users,
otel-launcher-javaonly had JUnit 4 throughpowermock-module-junit4. Once the PowerMock dependencies were removed, its tests no longer compiled:package org.junit does not exist, about 170 errors.Modules without that PowerMock module, and modules that already declare JUnit, are left unchanged, as covered by the new tests.
Corpus check
Mockito1to4Migration:otel-launcher-javanow compiles. Its remaining 9 test errors come frommockStatic(System.class), which Disable unsupported PowerMock tests before migrating them #1148 disables instead of migrating. With both changes, the build is green.zip4j,qmq(Maven) andgigya-java-sdk(Gradle) already declare JUnit, so no dependency is added and their results are unchanged.