Skip to content

tests: stabilize flaky tests in CI #2523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tzssangglass wants to merge 3 commits into
base: master
Choose a base branch
from
+9 −6
Open

tests: stabilize flaky tests in CI #2523

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
052e341
tests: fix flaky socket tests by resolving sslip.io instead of localhost
tzssangglass Sep 6, 2026
7bd03b4
tests: fix flaky t/189-http2-subreq-error-wakeup.t and t/024-access/o…
tzssangglass Sep 8, 2026
e137fce
tests: fix flaky t/128-duplex-tcp-socket.t TEST 4 in CI
tzssangglass Sep 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion t/014-bugs.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -884,7 +884,7 @@ ok
--- config
location /t {
resolver $TEST_NGINX_RESOLVER ipv6=off;
set $myhost 'localhost.';
set $myhost '127.0.0.1.sslip.io.';
proxy_pass http://$myhost:$TEST_NGINX_RAND_PORT_1/t;
}
--- request
Expand Down
2 changes: 1 addition & 1 deletion t/024-access/on-abort.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -372,7 +372,7 @@ delete thread 1
$
--- timeout: 0.2
--- abort
--- wait: 0.2
--- wait: 1
--- ignore_response
--- no_error_log
[error]
Expand Down
6 changes: 3 additions & 3 deletions t/058-tcp-socket.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,15 +210,15 @@ attempt to send data on a closed socket:
content_by_lua '
local sock = ngx.socket.tcp()
local port = $TEST_NGINX_SERVER_PORT
local ok, err = sock:connect("localhost", port)
local ok, err = sock:connect("127.0.0.1.sslip.io", port)
if not ok then
ngx.say("failed to connect: ", err)
return
end

ngx.say("connected: ", ok)

local req = "GET /foo HTTP/1.0\\r\\nHost: localhost\\r\\nConnection: close\\r\\n\\r\\n"
local req = "GET /foo HTTP/1.0\\r\\nHost: 127.0.0.1.sslip.io\\r\\nConnection: close\\r\\n\\r\\n"
-- req = "OK"

local bytes, err = sock:send(req)
Expand Down Expand Up @@ -256,7 +256,7 @@ attempt to send data on a closed socket:
GET /t
--- response_body_like
connected: 1
request sent: 57
request sent: 66
first line received: HTTP\/1\.1 200 OK
second line received: (?:Date|Server): .*?
--- no_error_log
Expand Down
2 changes: 1 addition & 1 deletion t/128-duplex-tcp-socket.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,7 +355,7 @@ F(ngx_http_lua_socket_tcp_finalize_write_part) {
--- tcp_query_len: 11
--- no_error_log
[error]
--- wait: 0.05
--- wait: 0.5



Expand Down
3 changes: 3 additions & 0 deletions t/189-http2-subreq-error-wakeup.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ __DATA__
--- http2
--- request
GET /delay
--- curl_options: --max-time=0.9
--- timeout: 1
--- abort
--- ignore_response
Expand Down Expand Up @@ -100,6 +101,7 @@ Parent request finished, got response from subrequest
--- http2
--- request
GET /outer
--- curl_options: --max-time=0.9
--- timeout: 1
--- abort
--- ignore_response
Expand Down Expand Up @@ -160,6 +162,7 @@ Outer request completed
--- http2
--- request
GET /parallel
--- curl_options: --max-time=0.9
--- timeout: 1
--- abort
--- ignore_response
Expand Down