Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Port of openproblems-bio/task_template#23:
run_benchmarkruns parameterised methods once per named paramset, from the method'sinfo.variantsor a--paramsetsyaml file, tags the scores withparamset_name/paramset, and lets--methods_include/--methods_excludetarget<method_id>.<paramset_name>. Uses the paramset helpers from common_resources #41 (submodule bumped).The existing
info.variantsin this repo predate this and needed cleaning up, since a method with variants now runs only those variants and viash drops empty ones:*_scranvariants (knn,logistic_regression,mlp,naive_bayes,xgboost): they only overridepreferred_normalization, which is not an argument, for a normalisation this task doesn't produce. These methods now simply run with their defaults.scanvi_scarches,scgpt_finetuned,scgpt_zeroshot,seurat_transferdataandsingler(a no-op).<method>.<paramset>:scprint.{large,medium,small},scanvi.{all_genes,hvg},cellmapper_scvi.{hnoca_hvg,gauss_hvg,gauss_all_genes},cellmapper_linear.{pca,cca}.scanvi'sall_genesvariant is spelled out asnum_hvg: 0(the script already treats a falsy value as "all genes"), since an empty variant is dropped by viash.cellmapper_linear: theccavariant useduse_rep: None, which YAML reads as the string"None"and would make cellmapper look upobsm["None"].--use_repis now optional without a default and the variant simply leaves it out, so cellmapper falls back to CCA. Note this changes the component's standalone default from PCA to the CCA fallback.Tested locally on the test resources: with the config variants,
cellmapper_linearrunspca(use_rep=X_pca) andcca(nouse_rep, fast_cca fallback) per dataset andknnruns once untagged; with a--paramsetsfile formlpandmethods_include: [knn, mlp.small], onlymlp.smallruns with the given arguments. Score rows carryparamset_name/paramsetin both cases.Checklist before requesting a review
I have performed a self-review of my code
Check the correct box. Does this PR contain:
Proposed changes are described in the CHANGELOG.md
CI Tests succeed and look good!