Skip to content

Add BERNN batch integration method - #117

Open
spell00 wants to merge 7 commits into
openproblems-bio:mainfrom
spell00:method/bernn-clean-main
Open

spell00 wants to merge 7 commits into
openproblems-bio:mainfrom
spell00:method/bernn-clean-main

Conversation

@spell00

@spell00 spell00 commented Oct 14, 2026 •

Copy link
Copy Markdown

Describe your changes

This PR adds BERNN (Batch Effect Removal Neural Network) as a new method for the OpenProblems batch integration benchmark.

BERNN is a neural network-based approach designed to reduce technical batch effects while preserving biological information.

Changes include:

  • Add the BERNN method implementation and Viash configuration.
  • Register BERNN in the benchmark workflow.
  • Update CHANGELOG.md.

Reference: https://doi.org/10.1038/s41467-024-48177-5

Checklist before requesting a review

  • I have performed a self-review of my code

  • Check the correct box. Does this PR contain:

    • Breaking changes
    • New functionality
    • Major changes
    • Minor changes
    • Bug fixes
  • Proposed changes are described in the CHANGELOG.md

  • CI Tests succeed and look good!

@spell00
spell00 marked this pull request as ready for review October 14, 2026 16:04

@rcannood rcannood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @spell00 ! Thanks for the contribution!

I left some comments for you to review.

In addition, could you also add yourself as a contributor to the _viash.yaml authors?

Comment thread src/methods/bernn/config.vsh.yaml Outdated
Comment thread src/methods/bernn/config.vsh.yaml Outdated
Comment thread src/methods/bernn/config.vsh.yaml
Comment thread src/methods/bernn/config.vsh.yaml Outdated
@spell00

spell00 commented Oct 19, 2026

Copy link
Copy Markdown
Author

Hi @rcannood! Thanks for the quick review, the pleasure is all mine!

I've addressed all your comments and pushed the corresponding changes. Let me know if anything else needs adjusting!

spell00

This comment was marked as duplicate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants