Skip to content

Gate renderer/custom-defines fields behind Advanced options #655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danoli3 merged 1 commit into from
Sep 22, 2026
Merged

Gate renderer/custom-defines fields behind Advanced options #655

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 16 additions & 8 deletions frontend/app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -973,14 +973,7 @@ function setup() {
console.log(arg);
ipcRenderer.send('refreshTemplateList', arg);

// renderer choice (OF_USE_ANGLE / OF_USE_DAWN) only applies to the Xcode-based
// osx/ios/macos (mega iOS/tvOS/macOS) targets
const rendererPlatforms = ['osx', 'ios', 'macos'];
if (selectedPlatformArray.some((p) => rendererPlatforms.includes(p))) {
$('#rendererField').show();
} else {
$('#rendererField').hide();
}
updateRendererFieldVisibility();
})
$("#platformsDropdownMulti").on('change', () => {
const selectedPlatforms = $("#platformsDropdownMulti input").val();
Expand Down Expand Up @@ -1314,6 +1307,7 @@ function enableAdvancedMode(isAdvanced) {
$('#templateSectionMulti').show();
$('#ofPathButton').show();
$('#emsdkField').show();
$('#customDefinesField').show();
if (!defaultSettings['detachConsole']) {
$('body').addClass('showConsole');
}
Expand All @@ -1331,14 +1325,28 @@ function enableAdvancedMode(isAdvanced) {

$('#ofPathButton').hide();
$('#emsdkField').hide();
$('#customDefinesField').hide();
$("body").removeClass('advanced');
$('a.updateMultiMenuOption').hide();
}
defaultSettings.advancedMode = isAdvanced;
saveDefaultSettings();
updateRendererFieldVisibility();
//$("#advancedToggle").prop('checked', defaultSettings['advancedMode'] );
}

// renderer choice (OF_USE_ANGLE / OF_USE_DAWN) only applies to the Xcode-based
// osx/ios/macos (mega iOS/tvOS/macOS) targets, and is an advanced-only option
function updateRendererFieldVisibility() {
const rendererPlatforms = ['osx', 'ios', 'macos'];
const selectedPlatforms = ($("#platformsDropdown input").val() || '').trim().split(',');
if (defaultSettings.advancedMode && selectedPlatforms.some((p) => rendererPlatforms.includes(p))) {
$('#rendererField').show();
} else {
$('#rendererField').hide();
}
}

//----------------------------------------
function getPlatformList() {
const platformsPicked = $("#platformsDropdown .active");
Expand Down
13 changes: 8 additions & 5 deletions frontend/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,15 +233,18 @@
<div class="ui selection dropdown" id="rendererDropdown">
<input type="hidden" id="rendererValue" value="default">
<i class="dropdown icon"></i>
<div class="text">Default (OpenGL)</div>
<div class="text">Default (OpenGL / OpenGL ES)</div>
<!-- labels assume the Metal backend since this field is currently only
shown for osx/ios/macos - update if/when Linux/Windows ANGLE-Vulkan
or Dawn-Vulkan packages are actually available to build against -->
<div class="menu">
<div class="item" data-value="default">Default (OpenGL)</div>
<div class="item" data-value="angle">ANGLE (OF_USE_ANGLE)</div>
<div class="item" data-value="dawn">Dawn / WebGPU (OF_USE_DAWN)</div>
<div class="item" data-value="default">Default (OpenGL / OpenGL ES)</div>
<div class="item" data-value="angle">ANGLE - Auto OpenGL to Metal</div>
<div class="item" data-value="dawn">Dawn - Auto OpenGL to WebGPU/Metal</div>
</div>
</div>
</div>
<div class="field">
<div class="field advanced" id="customDefinesField" style="display: none">
<label>Custom defines: &nbsp;
<a class="ui icon tooltip" href="#" data-content="Comma-separated preprocessor defines, e.g. MY_FLAG,OTHER_FLAG=1" data-position="right center">
<i class="help circle icon"></i>
Expand Down
Loading