Conversation
|
Thanks for the pull request, @dcoa! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Description
This PR updates the course optimizer endpoints with authz permissions systems. The frontend validates access to the tool with edit permissions but the actions are still using the previous authorization system.
With this change, roles such as course editors can run the Course Optimizer. All four endpoints check the openedx-authz
courses.edit_course_contentpermission.Testing instructions
Setup
/admin/waffle_utils/waffleflagcourseoverridemodel/), add a course override set to Force On for:contentstore.enable_course_optimizercontentstore.enable_course_optimizer_check_prev_run_links(only needed for scenario 4)authz.enable_course_authoring, set to Force On.Scenario 1: a course editor can use the tool
POST /api/contentstore/v0/link_check/<course_id>returns 200 {"LinkCheckStatus": "Pending"}.GET /api/contentstore/v0/link_check_status/<course_id>returns 200, and the scan results appear.Scenario 2: a course auditor is denied
GET <studio>/api/contentstore/v0/link_check_status/<course_id>and<studio>/api/contentstore/v0/rerun_link_update_status/<course_id>. Both return 403.Scenario 3: behaviour is unchanged when authz is off
Scenario 4: previous-run link updates (optional)
This needs
contentstore.enable_course_optimizer_check_prev_run_linksand a rerun course whose content links to the original run.POST /api/contentourse_id>with{"action": "single", ...}returns 200.Pollingrerun_link_update_statusreturns 200 with results.{"action": "all"}returns 200.