-
Notifications
You must be signed in to change notification settings - Fork 4.4k
feat: default the authn MFE (logistration) on #39092
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
10a9eca
a151eff
284c0eb
822af4a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -25,7 +25,10 @@ | |
|
|
||
| @skip_unless_lms | ||
| @ddt.ddt | ||
| @override_settings(EMBARGO=True) | ||
| # ENABLE_AUTHN_MICROFRONTEND defaults to True, which sends /login and /register on to the | ||
| # authn MFE. Most of this class covers the legacy page these URLs still render when the MFE | ||
| # is off, so pin the flag here; the handful of MFE-redirect tests re-enable it per-method. | ||
| @override_settings(EMBARGO=True, ENABLE_AUTHN_MICROFRONTEND=False) | ||
| class LoginAndRegistrationTest(ThirdPartyAuthTestMixin, UrlResetMixin, ModuleStoreTestCase): | ||
| """ Tests for Login and Registration. """ | ||
| USERNAME = "bob" | ||
|
|
@@ -417,6 +420,7 @@ def test_browser_language_dialent(self): | |
|
|
||
|
|
||
| @skip_unless_lms | ||
| @override_settings(ENABLE_AUTHN_MICROFRONTEND=False) | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same question: delete this whole test class when legacy logistration is removed? or is there core logic being tested that we need to factor out?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same answer. |
||
| class AccountCreationTestCaseWithSiteOverrides(SiteMixin, TestCase): | ||
| """ | ||
| Test cases for Feature flag ALLOW_PUBLIC_ACCOUNT_CREATION which when | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should all the
ENABLE_AUTHN_MICROFRONTEND=Falsetest methods be deleted when legacy logistration is removed? or is there core logic being tested that we need to factor out?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of these will be deleted when the legacy logistration is dropped but that won't be for a minute since there is some enterprise capability that has not been ported to the MFE yet.