fix: throttle cache key fixed for same scoped classes#38850
fix: throttle cache key fixed for same scoped classes#38850marslanabdulrauf wants to merge 2 commits into
Conversation
|
Thanks for the pull request, @marslanabdulrauf! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
There was a problem hiding this comment.
Pull request overview
This pull request adds cache-key namespacing to several custom DRF throttling classes so that throttles with the same scope (e.g., "user", "staff") do not unintentionally share the same rate-limit bucket across different API endpoints.
Changes:
- Prefixed
EnrollmentUserThrottlecache keys withenrollment.. - Prefixed
CourseListUserThrottlecache keys withcourse_list.. - Prefixed
CourseIdListUserThrottlecache keys withcourse_id_list..
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| openedx/core/djangoapps/enrollments/views.py | Adds get_cache_key override to namespace enrollment throttle cache keys. |
| lms/djangoapps/course_api/views.py | Adds get_cache_key overrides to namespace course list and course-id list throttle cache keys. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Hi, DRF supports scoped throttling; there might be no need for a cache key mechanism https://www.django-rest-framework.org/api-guide/throttling/#scopedratethrottle |
In our case we need UserRateThrottle which is scoped per user while ScopedRateThrottle is per specific parts of the API. It has no concept of varying the rate by "who" is calling. |
293eb87 to
143872f
Compare
Description
This pull request introduces namespacing to the cache keys used by custom throttling classes in API views. By prefixing each throttle's cache key, it ensures that rate-limiting buckets are unique to each throttle, preventing unintended sharing of rate limits across different API endpoints that might use the same scope name.
Improvements to throttling cache key namespacing:
get_cache_keymethod to the custom throttle class inlms/djangoapps/course_api/views.pyto prefix the cache key withcourse_list., ensuring isolation of rate-limiting buckets for the course list API.get_cache_keymethod to the custom throttle class inlms/djangoapps/course_api/views.pyto prefix the cache key withcourse_id_list., ensuring isolation of rate-limiting buckets for the course ID list API.get_cache_keymethod to the custom throttle class inopenedx/core/djangoapps/enrollments/views.pyto prefix the cache key withenrollment., ensuring isolation of rate-limiting buckets for the enrollment API.Supporting information
https://github.com/mitodl/hq/issues/11918 (MIT Internal)
Testing instructions