test: add signal isolation class and methods#26
Merged
Conversation
mariajgrimaldi
force-pushed
the
MJG/isolate_signal_sending
branch
5 times, most recently
from
August 24, 2021 17:47
0b55c7c to
ae3d6e5
Compare
mariajgrimaldi
marked this pull request as ready for review
August 24, 2021 17:47
mariajgrimaldi
force-pushed
the
MJG/isolate_signal_sending
branch
from
August 24, 2021 17:57
4adacd3 to
497d091
Compare
felipemontoya
approved these changes
Aug 24, 2021
felipemontoya
left a comment
Member
There was a problem hiding this comment.
Once QA passes and the OpenEdxEventsTestCase docstring is complete I think we are ready to merge this.
mariajgrimaldi
force-pushed
the
MJG/isolate_signal_sending
branch
3 times, most recently
from
August 24, 2021 19:54
20918d9 to
0b6f5ba
Compare
mariajgrimaldi
force-pushed
the
MJG/isolate_signal_sending
branch
from
August 24, 2021 20:57
0b6f5ba to
a267869
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds classes and methods that allow developers to enable/disable events during testing. This implementation is a result of this discussion
Testing instructions:
make lms-shellUserAPITestCaseadd the mixinOpenEdxEventsTestCasepytest openedx/core/djangoapps/user_authn/views/tests/test_register.py::RegistrationValidationViewTestsReviewers:
Merge checklist:
Post merge:
finished.
Author concerns: List any concerns about this PR - inelegant
solutions, hacks, quick-and-dirty implementations, concerns about
migrations, etc.