Conversation
|
Thanks for the pull request, @cpruijsen! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Submit a signed contributor agreement (CLA)
If you've signed an agreement in the past, you may need to re-sign. Once you've signed the CLA, please allow 1 business day for it to be processed. 🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Setting django_response[name] for each webob header overwrote earlier Set-Cookie headers, so only the last cookie reached the client. Route Set-Cookie values through the response's cookie jar instead, which emits one header per cookie. Fixes openedx#523.
d214ba5 to
b541631
Compare
Only the last
Set-Cookieheader survives the WebOb to Django conversion.webob_to_django_responsein
xblock/django/request.pyassigns each header withdjango_response[name] = value, and a Djangoresponse's header mapping holds one value per name, so each cookie overwrites the previous one. A
handler that sets several cookies gets one.
Set-Cookieis the header where this matters, because it is the one servers legitimately send morethan once. This routes those headers into the response's cookie jar with
cookies.load(value), whichis the structure Django serialises each cookie from, and leaves every other header on the existing
path.
Changelog entry included, per the repo convention.
Fixes #523