fix: Stop pruning just-created workspace objects in default namespace - #12
Merged
Conversation
ntnn
changed the title
The controller records object GVK, Namespace and Name before applying to the workspace. If the object was missing the namespace the recorded identity had namespace="" and the returned identity namespace="default", resulting in the pruning pass deleting the object. Signed-off-by: Nelo-T. Wallus <red.brush9525@fastmail.com>
Perseus985
approved these changes
Jul 30, 2026
Perseus985
left a comment
Perseus985
left a comment
Contributor
There was a problem hiding this comment.
Good catch. Thanks and welcome :)
The red Realese Drafter run can be ignored. We fixed that for upcoming contributions ^^
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The controller records object GVK, Namespace and Name before applying to the workspace.
If the object was missing the namespace the recorded identity had namespace="" and the returned identity namespace="default", resulting in the pruning pass deleting the object.