Skip to content

OBPIH-7609 Putaway - assert receiving bins on create putaway page#79

Merged
alannadolny merged 6 commits intomainfrom
OBPIH-7609
Apr 21, 2026
Merged

OBPIH-7609 Putaway - assert receiving bins on create putaway page#79
alannadolny merged 6 commits intomainfrom
OBPIH-7609

Conversation

@kkrawczyk123
Copy link
Copy Markdown
Collaborator

added:

  • new elements to existing pages
  • added stock transfer dialog
  • test for asserting receiving bins on create putaway page

Copy link
Copy Markdown
Collaborator

@alannadolny alannadolny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+ Can you create a factory for (as an example) received stock movement?
Those "after each" are really big and started to be problematic for future maintenance. So if you can, it would be good to create a factor. I mean:

async function createReceivedStockMovement({
  productId,
  quantity,
  lot,
  expDate,
}) {
  // code
  return {
    stockMovement,
    receivingBin,
    shipmentId,
  };
}

And you there are a lot of repeated code for creating inbounds, etc., so it's not DRY

Comment thread src/pages/product/productShow/sections/components/StockTransferDialog.ts Outdated
Comment thread src/pages/product/productShow/sections/components/StockTransferDialog.ts Outdated
Comment thread src/pages/putaway/components/CreatePutawayTable.ts Outdated
Comment thread src/tests/putaway/assertReceivingBinsOnCreatePutawayPage.test.ts Outdated
Comment thread src/tests/putaway/assertReceivingBinsOnCreatePutawayPage.test.ts Outdated
@alannadolny alannadolny merged commit c6021f2 into main Apr 21, 2026
1 check passed
@alannadolny alannadolny deleted the OBPIH-7609 branch April 21, 2026 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants