chore: add cross-repo checklist to PR template and teach ship-pr to use it#125
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a cross-repo checklist section to the PR template and updates the
ship-prskill to read the template before opening a PR instead of using a hardcoded body.Why?
When a change spans multiple repos (e.g. CLI feature + docs update in openboot.dev), it's easy to forget the other repo. A checklist in the PR template surfaces the question at the right moment — for both humans and agents.
The
ship-prskill was previously writing its own--bodyunconditionally, which would silently discard the template. It now reads.github/pull_request_template.mdfirst and fills in its sections.Testing
go vet ./...passes./openboot install --dry-runor similar)Cross-repo checklist
openboot.dev?openboot-contractfirst)Notes for reviewer
Skill files under
.claude/skills/are not Go code — no unit tests apply. The change is verified by reading the before/after of the two modified files.