fix(lib): treat null message content as empty in parse_response - #3851
Open
chenlichao wants to merge 1 commit into
Open
fix(lib): treat null message content as empty in parse_response#3851chenlichao wants to merge 1 commit into
chenlichao wants to merge 1 commit into
Conversation
Responses parsing raised `TypeError: 'NoneType' object is not iterable` when a message output item had `content: null` - the same class of bug as null `output` fixed in openai#3345. Null reaches the parser because stream events are built without validation, and the same payload also passes the non-streaming path. Treat null content as empty with the same `or []` idiom used for null output, and add a regression test alongside the null-output tests. Fixes openai#3840
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes being requested
Fixes #3840
parse_response()insrc/openai/lib/_parsing/_responses.pyiteratesoutput.contentwithout a null guard, so a message output item withcontent: nullraisesTypeError: 'NoneType' object is not iterableinstead of parsing:Null reaches the parser because stream events are built without validation, and the same payload also passes the non-streaming path (reproduced with a mocked transport, both sync and async). This is the same class of bug as null
output, fixed in #3345.The fix applies the same
or []idiom used at line 61 for nulloutput(one line). The change is insrc/openai/lib/, which per CONTRIBUTING.md is handwritten and never modified by the generator, so no custom-code budget impact.Additional context & links
response.outputis null inresponse.completedevent (chatgpt.com Codex backend) #3325 / fix: preserve finalized output on null response completion #3345 (nulloutput), one level deeper: messagecontent.tests/lib/responses/test_null_output.pynext to the existing null-output tests, mirroring thetest_parse_response_with_null_outputpattern from fix: preserve finalized output on null response completion #3345.TypeErroron currentmain; new test fails without the fix and passes with it; fulltests/lib/responses/suite passes (96 passed);ruff checkclean on both files;git diff --checkclean. Diff is 2 files, +31/−2.