Skip to content

fix: validate http_client type in AsyncAPIClient #3110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
EaCognitive wants to merge 2 commits into
base: main
Choose a base branch
from
+6 −0
Open

fix: validate http_client type in AsyncAPIClient #3110

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c2fb49c
fix: validate http_client type in AsyncAPIClient to prevent cryptic T…
EaCognitive Apr 21, 2026
3941914
fix: address pyright warning for unnecessary isinstance check
EaCognitive Apr 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/openai/_base_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1498,6 +1498,12 @@ def __init__(
custom_headers=custom_headers,
_strict_response_validation=_strict_response_validation,
)
if http_client is not None and not isinstance(cast(Any, http_client), httpx.AsyncClient):
raise TypeError(
f"Expected http_client to be an instance of httpx.AsyncClient, but got {type(http_client)} instead. "
"If you are using AsyncOpenAI, you must pass an asynchronous HTTP client."
)

self._client = http_client or AsyncHttpxClientWrapper(
base_url=base_url,
# cast to a valid type because mypy doesn't understand our type narrowing
Expand Down