Skip to content

docs: fix streaming comment typo - #3005

Merged
marcuswood-oai merged 3 commits into
openai:mainfrom
Rohan5commit:docs/fix-streaming-comment-20260324
Sep 15, 2026
Merged

marcuswood-oai merged 3 commits into
openai:mainfrom
Rohan5commit:docs/fix-streaming-comment-20260324

Conversation

@Rohan5commit

Copy link
Copy Markdown
Contributor

Summary

  • fix a typo in the streaming chat completion comment

Related issue

  • N/A (trivial comment typo fix)

Guideline alignment

Validation

  • Not run (comment-only change)

@Rohan5commit
Rohan5commit requested a review from a team as a code owner March 24, 2026 05:26
Copilot AI review requested due to automatic review settings March 24, 2026 05:26

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR corrects a typo in an inline comment within the streaming chat completions accumulator, improving readability with no behavioral impact.

Changes:

  • Fix spelling in a comment (“continuosly” → “continuously”) in streaming chat completion accumulation logic.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 15, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-15T00:06:32.441993Z e52e0d5 New commits
🔒 Security Review Completed 2026-09-15T00:07:28.633901Z e52e0d5 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@marcuswood-oai marcuswood-oai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the correction. Reviewed after merging current main: the diff remains one comment-only spelling fix, and git diff --check passes. No runtime tests were run locally for this comment change; CI will validate the updated branch.

@github-actions

Copy link
Copy Markdown
Contributor

Castiron custom code

✅ No new custom-code files detected.

43 mixed files remain; 0 existing customizations changed.

Compared 718620397c38e52e0d5f87d6. Generated baselines verified.

43 existing customizations unchanged
  • api.md
  • scripts/castiron/README.md
  • scripts/castiron/custom_code_report.py
  • scripts/castiron/test_custom_code_report.py
  • src/openai/init.py
  • src/openai/_client.py
  • src/openai/resources/audio/transcriptions.py
  • src/openai/resources/audio/translations.py
  • src/openai/resources/beta/agents/sessions/sessions.py
  • src/openai/resources/beta/beta.py
  • src/openai/resources/beta/responses/responses.py
  • src/openai/resources/beta/threads/runs/runs.py
  • src/openai/resources/beta/threads/threads.py
  • src/openai/resources/chat/completions/completions.py
  • src/openai/resources/embeddings.py
  • src/openai/resources/files.py
  • src/openai/resources/live/forks.py
  • src/openai/resources/live/live.py
  • src/openai/resources/live/sideband.py
  • src/openai/resources/realtime/realtime.py
  • src/openai/resources/responses/responses.py
  • src/openai/resources/uploads/uploads.py
  • src/openai/resources/vector_stores/file_batches.py
  • src/openai/resources/vector_stores/files.py
  • src/openai/resources/videos.py
  • src/openai/resources/webhooks/init.py
  • src/openai/resources/webhooks/webhooks.py
  • src/openai/types/beta/agent_session_message.py
  • src/openai/types/chat/init.py
  • src/openai/types/chat/chat_completion_message_tool_call.py
  • src/openai/types/fine_tuning/fine_tuning_job_integration.py
  • src/openai/types/responses/init.py
  • src/openai/types/responses/response.py
  • src/openai/types/responses/response_function_web_search.py
  • src/openai/types/responses/response_function_web_search_param.py
  • src/openai/types/responses/responses_client_event.py
  • src/openai/types/responses/responses_client_event_param.py
  • src/openai/types/responses/tool.py
  • src/openai/types/responses/tool_param.py
  • src/openai/types/webhooks/init.py

3 more in the full report.

A changed generated baseline means this report cannot reliably identify which handwritten lines changed.

Inspect the custom-code diff

Download the exact patch produced by this run (requires repository access):

gh run download 34911943740 --repo openai/openai-python \
  --name castiron-custom-code-34911943740-1 --dir /tmp/castiron-custom-code-34911943740-1
git apply --stat /tmp/castiron-custom-code-34911943740-1/custom-code.patch
cat /tmp/castiron-custom-code-34911943740-1/custom-code.patch

Or reproduce it from an SDK checkout containing the vendored reporter:

git fetch --no-tags origin 718620397c38a546d2cbbc964983c286db7abf97 e52e0d5f87d60d0ae007c2246b0a3d0613e9e5ff
python3 scripts/castiron/custom_code_report.py report \
  --base 718620397c38a546d2cbbc964983c286db7abf97 \
  --head e52e0d5f87d60d0ae007c2246b0a3d0613e9e5ff --fetch --require-head-hash --public \
  --out /tmp/castiron-custom-code-e52e0d5f87d6
cat /tmp/castiron-custom-code-e52e0d5f87d6/custom-code.patch

This is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR.

Full report and patch

@marcuswood-oai marcuswood-oai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rechecked after merging the latest main update. The PR still contains only the same one-line comment correction, and git diff --check passes.

@marcuswood-oai
marcuswood-oai merged commit d421d7a into openai:main Sep 15, 2026
13 checks passed
@openai-sdks openai-sdks Bot mentioned this pull request Sep 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants