docs: fix streaming comment typo - #3005
marcuswood-oai merged 3 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR corrects a typo in an inline comment within the streaming chat completions accumulator, improving readability with no behavioral impact.
Changes:
- Fix spelling in a comment (“continuosly” → “continuously”) in streaming chat completion accumulation logic.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
marcuswood-oai
left a comment
There was a problem hiding this comment.
Thanks for the correction. Reviewed after merging current main: the diff remains one comment-only spelling fix, and git diff --check passes. No runtime tests were run locally for this comment change; CI will validate the updated branch.
Castiron custom code✅ No new custom-code files detected. 43 mixed files remain; 0 existing customizations changed. Compared 43 existing customizations unchanged
3 more in the full report. A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 34911943740 --repo openai/openai-python \
--name castiron-custom-code-34911943740-1 --dir /tmp/castiron-custom-code-34911943740-1
git apply --stat /tmp/castiron-custom-code-34911943740-1/custom-code.patch
cat /tmp/castiron-custom-code-34911943740-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin 718620397c38a546d2cbbc964983c286db7abf97 e52e0d5f87d60d0ae007c2246b0a3d0613e9e5ff
python3 scripts/castiron/custom_code_report.py report \
--base 718620397c38a546d2cbbc964983c286db7abf97 \
--head e52e0d5f87d60d0ae007c2246b0a3d0613e9e5ff --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-e52e0d5f87d6
cat /tmp/castiron-custom-code-e52e0d5f87d6/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
marcuswood-oai
left a comment
There was a problem hiding this comment.
Rechecked after merging the latest main update. The PR still contains only the same one-line comment correction, and git diff --check passes.
Summary
Related issue
Guideline alignment
src/openai/lib/, which the guide notes is safe for manual editsValidation