fix(apiform): encode typed nil readers as empty fields instead of panicking - #125
Closed
Hughhhhcoder wants to merge 1 commit into
Closed
fix(apiform): encode typed nil readers as empty fields instead of panicking#125Hughhhhcoder wants to merge 1 commit into
Hughhhhcoder wants to merge 1 commit into
Conversation
Hughhhhcoder
force-pushed
the
fix/typed-nil-reader-panic
branch
from
August 24, 2026 04:08
66b0c27 to
189de38
Compare
Author
|
The latest pull-request workflow runs ( |
Contributor
|
Thanks for the contribution. This duplicates #89 and the earlier PR #90, which already owns the original report. While reviewing both, I found that the shallow nil check still panicked when a typed-nil pointer was wrapped in an |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
encodeValueroutes any value whose type implementsio.ReaderintoencodeReaderbefore checking whether the value is a typed nil. A typed nil pointer (or nil interface) whose type implementsio.Readertherefore reachesencodeReader, which callsio.Copyon a nil receiver and panics.Fix
Move the nil check for
reflect.Pointerandreflect.Interfaceahead of theio.Readerinterface check, so typed nil values are encoded as empty fields instead of panicking.Test
Added a regression test in
internal/apiform/form_test.gocovering typed nilio.Readervalues.go test ./internal/apiform/...passes.