feat: #2886 add convenience properties to ToolCallItem and ToolCallOutputItem#2887
Closed
DanielCufino wants to merge 1 commit intoopenai:mainfrom
Closed
feat: #2886 add convenience properties to ToolCallItem and ToolCallOutputItem#2887DanielCufino wants to merge 1 commit intoopenai:mainfrom
DanielCufino wants to merge 1 commit intoopenai:mainfrom
Conversation
… and ToolCallOutputItem ToolApprovalItem already exposes tool_name and call_id as properties, but ToolCallItem and ToolCallOutputItem require users to reach into raw_item internals. This adds the same convenience accessors to both classes, following the existing ToolApprovalItem patterns. Closes openai#2886
DanielCufino
force-pushed
the
feat/tool-call-item-convenience-properties
branch
from
316215f to
59c9174
Compare
4 tasks
Member
|
@DanielCufino Thanks for putting this together. I'll #3027 instead because it carries the same additive API surface on current |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ToolApprovalItemexposestool_nameandcall_idas properties for easy inspection of tool calls.ToolCallItemandToolCallOutputItemlack equivalent accessors, requiring users to reach intoraw_iteminternals withgetattrchains andisinstancechecks.This adds the same convenience properties to both classes, following the existing
ToolApprovalItempatterns:ToolCallItem:tool_name,call_idToolCallOutputItem:call_idTest plan
make format— passmake lint— passmypy src/agents/items.py— passtests/test_items_helpers.pypasses (31 tests, no regressions)Issue number
Closes #2886
Checks
make lintandmake format