codex: retain topic approvals and close published reviews - #42
Draft
ttaylorr-oai wants to merge 1 commit into
Draft
codex: retain topic approvals and close published reviews#42ttaylorr-oai wants to merge 1 commit into
ttaylorr-oai wants to merge 1 commit into
Conversation
Topic pull requests are review-only, but plan admission currently requires an independent approval at the exact current source commit. Every subsequent push therefore forces the reviewer to approve again, even though GitHub still considers the earlier review effective. Retain the latest effective approval from an independent repository writer while continuing to freeze the exact source admitted into the plan. Keep the stricter exact-head check for legacy merge admission. After either publication path succeeds, inspect trusted plan history and close only topic pull requests whose current head matches the published source, generated output, and live repository refs. Leave source refs untouched, and make closure failures non-fatal after an otherwise successful publication.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Codex topic PRs are review-only, but plan admission currently discards an
otherwise valid approval whenever the topic head moves. Reviewers must approve
the same PR repeatedly even though GitHub still considers the earlier review
effective.
Those PRs also remain open after publication when the controller rebases their
source commits: the generated lane contains the rewritten commit, not the PR
head, and pinned-plan publication intentionally leaves source refs unchanged.
Changes
pushes while still freezing the exact current source head and rejecting
self-reviews, outside reviewers, dismissals, and requests for changes.
path.
whose trusted plan, published source pin, generated output, and current PR
identity still agree.
failures as warnings after an otherwise successful publication. GitHub marks
these review-only PRs closed, not merged.
behavior, and false-positive closure cases in the controller tests.
Validation
sh -n .github/workflows/codex-branch.sh t/t9905-codex-branch.shgit diff --checkt/t9905-codex-branch.shapproval, immutable-pin, publication, andpost-publication closure coverage.