Support GPT-5.6 models and refresh stale brokers#471
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1386a5ba56
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| let threadId; | ||
| let threadSelection; | ||
|
|
||
| await validateExplicitReasoningSelection(client, cwd, options); |
There was a problem hiding this comment.
Defer resume effort validation until after resume
When --resume is used, this prevalidation reads the current Codex config before thread/resume returns the persisted thread's actual model/provider. If the saved thread differs from the current config, valid resumes can be rejected locally; for example, resuming a gpt-5.6-sol thread with --effort ultra fails when the current config model is gpt-5.6-luna, even though the resumed thread supports ultra. The validation for resumed turns should use the thread/resume response instead of the current config.
Useful? React with 👍 / 👎.
Summary
maxandultrareasoning efforts across task, review, and adversarial-review flowsgpt-5.6-luna+ultralocally with a clear error--model/--effortfor review commandsRoot cause
The reported false upgrade error was not caused by
clientInfo.versionorserviceName. Controlled probes against Codex CLI 0.144.0 returned the same GPT-5.6 catalog for plugin client version 1.0.6 and CLI client version 0.144.0, and a real plugin-path GPT-5.6 turn succeeded with the existing service name.The failure occurs when the plugin reuses a broker that was started before the Codex CLI upgrade. That broker keeps its original
codex app-serverchild in memory, so a locally installed 0.144.0 CLI can still route plugin turns through an older app-server. Broker state now records both plugin and CLI versions and is invalidated atomically when either changes or when legacy state has no runtime identity.Validation
npm cinpm run check-versionnpm run build(including app-server binding generation)npm test— 107/107 passingmodel/list, stale CLI/plugin versions, legacy broker state, concurrent startup, and abandoned-lock recoverygpt-5.6-sol/highgpt-5.6-terra/maxgpt-5.6-luna/highFixes #468.
Related to #309, which reports the same false “requires a newer version” symptom and direct-CLI/plugin-runtime mismatch; this PR fixes the stale shared-broker path and also exposes review model/effort selection.