Accept GPT-5.6 max and ultra reasoning efforts#466
Closed
vadimcomanescu wants to merge 1 commit into
Closed
Conversation
The effort allowlist in codex-companion.mjs stops at xhigh, so the plugin rejects gpt-5.6-sol dispatches at max or ultra before any Codex thread starts, while the codex CLI itself accepts them. Adds both values to the allowlist, the usage and error strings, the rescue command argument hint, and the runtime skill doc (noting they need a model that supports them).
Author
|
Duplicate of #454 — closing in its favor. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
taskcommand's effort allowlist (VALID_REASONING_EFFORTSinplugins/codex/scripts/codex-companion.mjs) stops atxhigh, so--effort maxand--effort ultraare rejected withUnsupported reasoning effortbefore any Codex thread starts — while thecodexCLI itself accepts both for models that support them (e.g.gpt-5.6-sol).Changes
maxandultratoVALID_REASONING_EFFORTS, the usage string, and the error message incodex-companion.mjs--effortargument hint incommands/rescue.mdskills/codex-cli-runtime/SKILL.md, noting the two new values require a model that supports themtests/commands.test.mjsthat pin the documented effort listsTesting
node --test tests/commands.test.mjspasses (8/8). Validation verified manually:task --effort ultraproceeds past effort validation; an unknown value is still rejected with the updated message. No version bump included — left to your release process.🤖 Generated with Claude Code