Repository navigation
Conversation
The examples spec ignored failures mentioning beta:virtualTour while it was temporarily removed from the beta namespace (openactive/models-lib#62). It has been in the beta namespace since, and now refers to schema:3DModel (openactive/ns-beta#42), so the examples validate without the exclusion: 36 example specs and the full suite (448 specs) pass with data-models 3.0.11 and the live beta namespace. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
data-models gives a stand-alone Organization (the top-level object, or an RPDE item's data, in feed mode) its own required and recommended fields, keyed by the containing field names `$` and `data`. Test both, and that an Organization used as an organizer is unaffected, so a change to either name is caught. Requires the data-models release with these rules. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The valid Organization now includes the beta namespace context and beta:dateVerified, with the beta namespace mocked as in the other tests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not merge until data-models 3.0.12 is released (openactive/data-models#213): the new tests need its Organization rules, so
testfails until then. Re-run the checks after the release.Merging releases 3.0.5 to npm and triggers the validator site and test suite. This is the first release to use the npm wait step (#518).
Summary
Test-only changes:
data, in feed mode) its own required and recommended fields, keyed by the containing field names$anddata. New tests insrc/validate-spec.jscheck a stand-alone Organization (including the requiredbeta:dateVerified, with the beta namespace mocked, and the requiredlicense) and an RPDE page of Organizations withoutlicenseon each item, and that an Organization used as anorganizeris unaffected. They also catch any change to how the validator names the root node ($) or the feed item'sdata.beta:virtualTourexclusion from the example tests. It was added whilebeta:virtualTourwas removed from the beta namespace because its reference to3DModelbroke the model libraries (Beta property reference to3DModelhas broken the generated libraries models-lib#62).beta:virtualTournow refers toschema:3DModel(Use core schema.org terms from 30.1 and add beta:dateVerified ns-beta#42), and the examples validate without the exclusion.Verification
With data-models from openactive/data-models#213: 456 specs, 0 failures, including lint and
place_example_1.json(the only example usingbeta:virtualTour).When squash-merging, check the suggested commit message does not contain a skip-CI marker.