Skip to content

fix: report strictRoot error relative to the parsed range - #1723

Open
tyler-yankee wants to merge 4 commits into
open-source-parsers:masterfrom
tyler-yankee:skip-bom-fix
Open

tyler-yankee wants to merge 4 commits into
open-source-parsers:masterfrom
tyler-yankee:skip-bom-fix

Conversation

@tyler-yankee

Copy link
Copy Markdown

Callers which turn offsets into positions in the buffer read out of bounds.

Callers which turn offsets into positions in the buffer read out of
bounds.
@greptile-apps

greptile-apps Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] The PR appears safe to merge.

Summary

Fixes strict-root error locations after the parser skips a UTF-8 BOM.

  • Strict-root errors stay within the range the reader parsed.

Reviews (4) · Last reviewed commit: "Merge branch 'master' into skip-bom-fix" · Reviewed by Greptile

@coveralls

coveralls commented Oct 26, 2026 •

Copy link
Copy Markdown

Coverage Report for CI Build 40353151984

Warning

Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes.
Quick fix: rebase this PR. Learn more →

Coverage remained the same at 90.132%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: 4 of 4 lines across 1 file are fully covered (100%).
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 2744
Covered Lines: 2626
Line Coverage: 95.7%
Relevant Branches: 2647
Covered Branches: 2233
Branch Coverage: 84.36%
Branches in Coverage %: Yes
Coverage Strength: 23810.29 hits per line

💛 - Coveralls

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants