Skip to content

fix: wrong function name in getCStringLength assertion message - #1713

Open
hilbert149 wants to merge 2 commits into
open-source-parsers:masterfrom
hilbert149:master
Open

hilbert149 wants to merge 2 commits into
open-source-parsers:masterfrom
hilbert149:master

Conversation

@hilbert149

Copy link
Copy Markdown

fix: wrong function name in getCStringLength assertion message

@greptile-apps

greptile-apps Bot commented Sep 3, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] This PR appears safe to merge.

Summary

Corrects the assertion message in Json::Value::getCStringLength() to name that function instead of asCString().

  • getCStringLength() names itself when a value is not a string.

Reviews (2) · Last reviewed commit: "Merge branch 'master' into master" · Reviewed by Greptile

@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 40347661409

Coverage remained the same at 89.926%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 2740
Covered Lines: 2615
Line Coverage: 95.44%
Relevant Branches: 2640
Covered Branches: 2223
Branch Coverage: 84.2%
Branches in Coverage %: Yes
Coverage Strength: 23835.16 hits per line

💛 - Coveralls

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants