Skip to content

fix(mcp): tell agents when create_entity needs approval - #35527

Queued
Vishnuujain wants to merge 2 commits into
mainfrom
fix/mcp-create-review-state
Queued

Vishnuujain wants to merge 2 commits into
mainfrom
fix/mcp-create-review-state

Conversation

@Vishnuujain

Copy link
Copy Markdown
Contributor

Describe your changes:

Fixes #33458

  • create_entity already returns entityStatus: Draft and the inherited reviewers when a term goes into approval, but the tool description said "Writes take effect immediately" and nothing told the agent what Draft means, so it still reported "created".
  • Added one sentence to the create_entity description: when the response has Draft or In Review and lists reviewers, tell the user it was submitted to those reviewers for approval.
  • The approval task is not in the response: the workflow starts after the create returns, so there is no task yet at that point.

Type of change:

  • Bug fix

Tests:

Unit tests

  • CreateEntityToolTest, McpSdkUpgradeTest: 44/44 pass. Description-only change, no new test.

Manual testing performed

  1. Restarted the local server on this branch: MCP tools/list returns the new create_entity description.
  2. create_entity for a glossary term in a glossary with reviewers returns "entityStatus":"Draft" plus the inherited reviewers; the term moves to In Review once the workflow picks it up.

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR is linked to a GitHub issue via Fixes #33458 above.

@github-actions

github-actions Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

✅ PR checks passed

The linked issue has a description and all required Shipping project fields set. Thanks!

@github-actions github-actions Bot added the safe to test Add this label to run secure Github workflows on PRs label Oct 15, 2026
@gitar-bot

gitar-bot Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Code Review ✅ Approved

🟡 Medium risk · The create_entity instruction changes agent reporting for approval-pending entities; misreading status or reviewer fields could incorrectly tell users approval was submitted.

Adds one sentence to the create_entity MCP tool description so agents tell users when a term was submitted to reviewers for approval (Draft or In Review status with listed reviewers) instead of reporting it as created. No issues found.

Verification

Rules No rules evaluated

Functional validation Not enabled

Set up

Auto-approval Not enabled

Set up

For more verification details, comment gitar display:verbose.

Options

Display: compact → Showing compact verification results.

Comment with these commands to change the behavior for this request:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Powered by Gitar — free for open source

@Vishnuujain Vishnuujain self-assigned this Oct 15, 2026
@Shreyansh100704
Shreyansh100704 added this pull request to the merge queue Oct 15, 2026
Any commits made after this event will not be merged.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MCP create_entity does not surface approval state

2 participants