Repository navigation
fix(mcp): tell agents when create_entity needs approval - #35527
Vishnuujain wants to merge 2 commits into
Conversation
✅ PR checks passedThe linked issue has a description and all required Shipping project fields set. Thanks! |
Code Review ✅ Approved🟡 Medium risk · The create_entity instruction changes agent reporting for approval-pending entities; misreading status or reviewer fields could incorrectly tell users approval was submitted. Adds one sentence to the VerificationRules No rules evaluated Functional validation Not enabledAuto-approval Not enabledFor more verification details, comment OptionsDisplay: compact → Showing compact verification results. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Powered by Gitar — free for open source |
Describe your changes:
Fixes #33458
create_entityalready returnsentityStatus: Draftand the inheritedreviewerswhen a term goes into approval, but the tool description said "Writes take effect immediately" and nothing told the agent what Draft means, so it still reported "created".create_entitydescription: when the response has Draft or In Review and lists reviewers, tell the user it was submitted to those reviewers for approval.Type of change:
Tests:
Unit tests
CreateEntityToolTest,McpSdkUpgradeTest: 44/44 pass. Description-only change, no new test.Manual testing performed
tools/listreturns the newcreate_entitydescription.create_entityfor a glossary term in a glossary with reviewers returns"entityStatus":"Draft"plus the inherited reviewers; the term moves to In Review once the workflow picks it up.Checklist:
Fixes #33458above.