Skip to content

chore(alerts): remove the package-info files added by the alerting regroup - #35515

Merged
manerow merged 1 commit into
mainfrom
chore/drop-alerting-package-info
Oct 15, 2026
Merged

manerow merged 1 commit into
mainfrom
chore/drop-alerting-package-info

Conversation

@manerow

@manerow manerow commented Oct 15, 2026

Copy link
Copy Markdown
Contributor

What this pull request does

The alerting regroup (PR #35032) added a package-info.java to each of the 23 packages under alerting and events.consumer, and to apps.bundles.insights.template. Each holds one Javadoc sentence and nothing else: no annotations, no imports. Nothing reads them (no test, Checkstyle rule or build step), and no other package in openmetadata-service has one, so they only made these packages look different from the rest. This removes all 24.

The rules they described stay where they are enforced: AlertingArchitectureTest fails the build when a package crosses its boundary, and the decision record in docs/decisions/ explains how an alert names its consumer.

How it was tested

A clean build of openmetadata-service with its dependencies, and AlertingArchitectureTest, ConsumersTest and EventSubscriptionMapperTest (14 tests), pass. Javadoc runs with doclint off in every module, so no build step needs package docs.

Fixes #35030

@manerow
manerow requested a review from a team as a code owner October 15, 2026 08:54
@manerow
manerow requested a review from sonika-shah October 15, 2026 08:54
@github-actions github-actions Bot added backend safe to test Add this label to run secure Github workflows on PRs labels Oct 15, 2026
@gitar-bot

gitar-bot Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Code Review ✅ Approved

🟢 Low risk · Removing 24 package-info files deletes only package Javadocs, leaving executable code and alerting behavior unchanged.

Removes the 24 one-sentence package-info.java files added by the alerting regroup from alerting, events.consumer and apps.bundles.insights.template. Nothing reads them, and the boundary rules remain enforced by AlertingArchitectureTest. No issues found.

Verification

Rules No rules evaluated

Functional validation Not enabled

Set up

Auto-approval Not enabled

Set up

For more verification details, comment gitar display:verbose.

Options

Display: compact → Showing compact verification results.

Comment with these commands to change the behavior for this request:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Powered by Gitar — free for open source

@manerow
manerow added this pull request to the merge queue Oct 15, 2026
Merged via the queue into main with commit 7db09b3 Oct 15, 2026
75 of 76 checks passed
@manerow
manerow deleted the chore/drop-alerting-package-info branch October 15, 2026 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend safe to test Add this label to run secure Github workflows on PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Give alerting code one home, with boundaries the build enforces

2 participants