Repository navigation
chore(alerts): remove the package-info files added by the alerting regroup - #35515
Merged
Merged
Conversation
Code Review ✅ Approved🟢 Low risk · Removing 24 package-info files deletes only package Javadocs, leaving executable code and alerting behavior unchanged. Removes the 24 one-sentence VerificationRules No rules evaluated Functional validation Not enabledAuto-approval Not enabledFor more verification details, comment OptionsDisplay: compact → Showing compact verification results. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Powered by Gitar — free for open source |
mohityadav766
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this pull request does
The alerting regroup (PR #35032) added a
package-info.javato each of the 23 packages underalertingandevents.consumer, and toapps.bundles.insights.template. Each holds one Javadoc sentence and nothing else: no annotations, no imports. Nothing reads them (no test, Checkstyle rule or build step), and no other package inopenmetadata-servicehas one, so they only made these packages look different from the rest. This removes all 24.The rules they described stay where they are enforced:
AlertingArchitectureTestfails the build when a package crosses its boundary, and the decision record indocs/decisions/explains how an alert names its consumer.How it was tested
A clean build of
openmetadata-servicewith its dependencies, andAlertingArchitectureTest,ConsumersTestandEventSubscriptionMapperTest(14 tests), pass. Javadoc runs withdoclintoff in every module, so no build step needs package docs.Fixes #35030