Skip to content

fix(e2e): re-add powerbi e2e tests - #35510

Queued
harshsoni2024 wants to merge 1 commit into
mainfrom
pbi-e2e-re-add
Queued

harshsoni2024 wants to merge 1 commit into
mainfrom
pbi-e2e-re-add

Conversation

@harshsoni2024

@harshsoni2024 harshsoni2024 commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Describe your changes:

  • re-adding powerbi e2e tests

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

High-level design:

N/A — small change.

Tests:

Use cases covered

Unit tests

Backend integration tests

Ingestion integration tests

Playwright (UI) tests

Manual testing performed

UI screen recording:

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • My PR is linked to a GitHub issue via Fixes #<issue-number> above.
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.
  • For a UI feature or feature task: as part of PR creation, I ran the PR build in Docker with sample data and embedded a verified GitHub-hosted recording plus build/health evidence above (or explained why this requirement is not applicable).
  • I have added tests (unit / integration / Playwright as applicable) and listed them above.
  • Decision check: if this PR decides something the next contributor could undo — a schema field, REST path or format another component or repo must agree with, a new default or limit, an ordering that must hold, or a rule stated only in this description — it adds a record under docs/decisions/ (see its README.md). This description is gone from git log after the squash-merge.

Summary by Gitar

  • CI changes:
    • Added powerbi to the default E2E test matrix in py-cli-e2e-tests.yml
  • Configuration:
    • Renamed dbServiceNames to dbServicePrefixes under lineageInformation in powerbi.yaml

This will update automatically on new commits.

Copilot AI balanced review requested due to automatic review settings October 15, 2026 08:18

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions

Copy link
Copy Markdown
Contributor

❌ PR checklist incomplete

This PR cannot be merged until the following are addressed on its linked issue:

  • No GitHub issue is linked. Link an issue in the Development section of the PR (or add Fixes #12345 to the description). For a same-org cross-repo issue, add Fixes open-metadata/<repo>#123 to the description.

The fields live on the linked issue in the Shipping project (open the issue → right sidebar → Projects). After you set them, re-run this check (or push a commit) — issue/project changes do not re-trigger it automatically.

Maintainers can bypass this check by adding the skip-pr-checks label.

@github-actions github-actions Bot added Ingestion safe to test Add this label to run secure Github workflows on PRs labels Oct 15, 2026
@gitar-bot

gitar-bot Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Code Review ✅ Approved

🟡 Medium risk · Adding Power BI to the default E2E matrix and changing its lineage config could expose workflows to test failures or incorrect lineage matching.

Re-adds PowerBI E2E tests by adding powerbi to the default matrix in py-cli-e2e-tests.yml and renaming dbServiceNames to dbServicePrefixes under lineageInformation in powerbi.yaml. No issues found.

Verification

Rules No rules evaluated

Functional validation Not enabled

Set up

Auto-approval Not enabled

Set up

For more verification details, comment gitar display:verbose.

Options

Display: compact → Showing compact verification results.

Comment with these commands to change the behavior for this request:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Powered by Gitar — free for open source

@sonarqubecloud

Copy link
Copy Markdown

@harshsoni2024

Copy link
Copy Markdown
Contributor Author

@harshsoni2024
harshsoni2024 added this pull request to the merge queue Oct 15, 2026
Any commits made after this event will not be merged.
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Oct 15, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🚦 Removed from the merge queue — failed_checks (2026-10-15T21:57:27Z)

Blocked the queue: playwright-summary

Failed Playwright tests:

  • Features/BulkEditEntity.spec.ts › Database Schema

@harshsoni2024
harshsoni2024 added this pull request to the merge queue Oct 16, 2026
Any commits made after this event will not be merged.

This branch was successfully deployed

1 active deployment
test — af629ebb Deployed Oct 15, 2026 by harshsoni2024 via py-cli-e2e-tests (powerbi) #1893
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ingestion safe to test Add this label to run secure Github workflows on PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants