fix(glossary): catch unhandled rejection in initializeGlossary on entity switch by anuj-kumary · Pull Request #31711 · open-metadata/OpenMetadata

anuj-kumary · 2026-08-18T16:11:17Z

Why

When navigating from a glossary page to a glossary-term page, isGlossaryActive flips to false before the Zustand activeGlossary store is updated with the term. The useEffect fires with isGlossaryActive = false but selectedData.id still holds the glossary UUID.

This causes fetchGlossaryTermPermission to call:

GET /api/v1/permissions/glossaryTerm/<glossary-uuid>

The backend returns 400 because that UUID belongs to a Glossary, not a GlossaryTerm.

fetchGlossaryTermPermission shows a toast and re-throws. Neither initPermissions nor initializeGlossary had a catch, and the useEffect calls initializeGlossary() without await or .catch() — so the rejection became an unhandled promise rejection surfaced to the global error handler.

Fix

Wrap initializeGlossary's body in a try/catch. The catch resets isLoading so the spinner is never left hanging; the error toast is already shown by fetchGlossaryTermPermission before it re-throws, so no second notification is needed.

Test plan

Navigate from a glossary to one of its child terms — no unhandled rejection in the browser console
Glossary permission 403 / 400 shows a toast but does not crash the page or leave a spinner stuck
Version view still works (isVersionsView = true path is unchanged)

🤖 Generated with Claude Code

Greptile Summary

The PR prevents a glossary permission-fetch failure from becoming an unhandled promise rejection and ensures the page loading state is cleared.

Wraps glossary initialization in error handling.
Preserves the existing permission error notification without displaying a duplicate toast.
Clears the loading state when permission initialization fails.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename	Overview
openmetadata-ui/src/main/resources/ui/src/components/Glossary/GlossaryV1.component.tsx	Adds targeted rejection handling around permission initialization and clears loading state on failure.

_{Reviews (2): Last reviewed commit: "Merge branch 'main' into fix/glossary-un..." | Re-trigger Greptile}

…ity switch When navigating from a glossary to a term, isGlossaryActive flips to false before the Zustand store updates activeGlossary, causing fetchGlossaryTermPermission to call GET /permissions/glossaryTerm with a glossary UUID → 400 from the backend. The permission helper already shows a toast and re-throws; initPermissions and initializeGlossary both lacked a catch, so the rejection propagated through the unawaited useEffect call and became an unhandled promise rejection. Add try/catch to initializeGlossary so the error is contained, loading state is always reset, and no unhandled rejection reaches the global error handler. Fixes: Sentry issue 7678621940

github-actions · 2026-08-18T16:11:27Z

❌ PR checklist incomplete

This PR cannot be merged until the following are addressed on its linked issue:

No GitHub issue is linked. Link an issue in the Development section of the PR (or add Fixes #12345 to the description). For a same-org cross-repo issue, add Fixes open-metadata/<repo>#123 to the description.

The fields live on the linked issue in the Shipping project (open the issue → right sidebar → Projects). After you set them, re-run this check (or push a commit) — issue/project changes do not re-trigger it automatically.

Maintainers can bypass this check by adding the skip-pr-checks label.

github-actions · 2026-08-18T16:11:40Z

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

github-actions · 2026-08-18T16:12:39Z

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

gitar-bot · 2026-08-18T16:15:52Z

Code Review ✅ Approved

Catches unhandled promise rejections during glossary permission initialization and entity switches, preventing global error crashes and stuck loading spinners. No issues found.

Options

Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

`Compact`
`gitar display:verbose`

_{Was this helpful? React with 👍 / 👎 | Powered by Gitar — free for open source}

github-actions · 2026-08-18T16:30:47Z

Jest test Coverage

UI tests summary

Lines	Statements	Branches	Functions
	66.89% (80117/119761)	51.24% (48854/95329)	52.29% (14642/28001)

github-actions · 2026-08-19T02:17:10Z

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

sonarqubecloud · 2026-08-19T02:34:09Z

Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

github-actions · 2026-08-19T12:40:25Z

Changes have been cherry-picked to the 2.0 branch.

…ity switch (#31711) When navigating from a glossary to a term, isGlossaryActive flips to false before the Zustand store updates activeGlossary, causing fetchGlossaryTermPermission to call GET /permissions/glossaryTerm with a glossary UUID → 400 from the backend. The permission helper already shows a toast and re-throws; initPermissions and initializeGlossary both lacked a catch, so the rejection propagated through the unawaited useEffect call and became an unhandled promise rejection. Add try/catch to initializeGlossary so the error is contained, loading state is always reset, and no unhandled rejection reaches the global error handler. Fixes: Sentry issue 7678621940 (cherry picked from commit d08490c)

github-actions · 2026-08-19T12:41:31Z

Changes have been cherry-picked to the 1.13 branch.

…ity switch (#31711) When navigating from a glossary to a term, isGlossaryActive flips to false before the Zustand store updates activeGlossary, causing fetchGlossaryTermPermission to call GET /permissions/glossaryTerm with a glossary UUID → 400 from the backend. The permission helper already shows a toast and re-throws; initPermissions and initializeGlossary both lacked a catch, so the rejection propagated through the unawaited useEffect call and became an unhandled promise rejection. Add try/catch to initializeGlossary so the error is contained, loading state is always reset, and no unhandled rejection reaches the global error handler. Fixes: Sentry issue 7678621940 (cherry picked from commit d08490c)

anuj-kumary requested review from ShaileshParmar11, chirag-madlani and karanh37 as code owners August 18, 2026 16:11

anuj-kumary self-assigned this Aug 18, 2026

github-actions Bot added the UI UI specific issues label Aug 18, 2026

anuj-kumary added skip-pr-checks Bypass PR metadata validation check and removed UI UI specific issues labels Aug 18, 2026

anuj-kumary added the safe to test Add this label to run secure Github workflows on PRs label Aug 18, 2026

Merge branch 'main' into fix/glossary-unhandled-rejection

3cec061

github-actions Bot added UI UI specific issues and removed safe to test Add this label to run secure Github workflows on PRs labels Aug 18, 2026

anuj-kumary added the safe to test Add this label to run secure Github workflows on PRs label Aug 18, 2026

chirag-madlani approved these changes Aug 18, 2026

View reviewed changes

Merge branch 'main' into fix/glossary-unhandled-rejection

ec35444

github-actions Bot removed the safe to test Add this label to run secure Github workflows on PRs label Aug 19, 2026

anuj-kumary added the safe to test Add this label to run secure Github workflows on PRs label Aug 19, 2026

anuj-kumary enabled auto-merge August 19, 2026 02:44

anuj-kumary temporarily deployed to test August 19, 2026 02:55 — with GitHub Actions Inactive

anuj-kumary had a problem deploying to test August 19, 2026 02:55 — with GitHub Actions Failure

anuj-kumary temporarily deployed to test August 19, 2026 02:55 — with GitHub Actions Inactive

anuj-kumary added this pull request to the merge queue Aug 19, 2026

anuj-kumary added the To release Will cherry-pick this PR into the release branch label Aug 19, 2026

Merged via the queue into open-metadata:main with commit d08490c Aug 19, 2026
209 of 217 checks passed

anuj-kumary deleted the fix/glossary-unhandled-rejection branch August 19, 2026 12:38

Navigation Menu

Uh oh!

fix(glossary): catch unhandled rejection in initializeGlossary on entity switch - #31711

fix(glossary): catch unhandled rejection in initializeGlossary on entity switch#31711
anuj-kumary merged 3 commits into
open-metadata:mainfrom
anuj-kumary:fix/glossary-unhandled-rejection

anuj-kumary commented Aug 18, 2026 •

edited by greptile-apps Bot

Loading

Uh oh!

github-actions Bot commented Aug 18, 2026

Uh oh!

github-actions Bot commented Aug 18, 2026

Uh oh!

github-actions Bot commented Aug 18, 2026

Uh oh!

gitar-bot Bot commented Aug 18, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Aug 18, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Aug 19, 2026

Uh oh!

sonarqubecloud Bot commented Aug 19, 2026

Uh oh!

Uh oh!

github-actions Bot commented Aug 19, 2026

Uh oh!

github-actions Bot commented Aug 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

anuj-kumary commented Aug 18, 2026 • edited by greptile-apps Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Why

Fix

Test plan

Greptile Summary

Confidence Score: 5/5

Important Files Changed

Uh oh!

github-actions Bot commented Aug 18, 2026

❌ PR checklist incomplete

Uh oh!

github-actions Bot commented Aug 18, 2026

Uh oh!

github-actions Bot commented Aug 18, 2026

Uh oh!

gitar-bot Bot commented Aug 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Aug 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Jest test Coverage

UI tests summary

Uh oh!

github-actions Bot commented Aug 19, 2026

Uh oh!

sonarqubecloud Bot commented Aug 19, 2026

Quality Gate passed for 'open-metadata-ui'

Uh oh!

Uh oh!

github-actions Bot commented Aug 19, 2026

Uh oh!

github-actions Bot commented Aug 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

anuj-kumary commented Aug 18, 2026 •

edited by greptile-apps Bot

Loading

gitar-bot Bot commented Aug 18, 2026 •

edited

Loading

github-actions Bot commented Aug 18, 2026 •

edited

Loading