Skip to content

fix(data-products): remove Lifecycle Stage from Data Products filters - #31703

Merged
anuj-kumary merged 2 commits into
mainfrom
fix/remove-lifecycle-stage-data-products-filter
Aug 19, 2026
Merged

fix(data-products): remove Lifecycle Stage from Data Products filters#31703
anuj-kumary merged 2 commits into
mainfrom
fix/remove-lifecycle-stage-data-products-filter

Conversation

@anuj-kumary

@anuj-kumary anuj-kumary commented Aug 18, 2026

Copy link
Copy Markdown
Member

Summary

  • Removes EntityFields.LIFECYCLE_STAGE from DATAPRODUCT_DEFAULT_QUICK_FILTERS
  • Removes the Lifecycle Stage entry from DATAPRODUCT_FILTERS

The Lifecycle Stage filter was removed from general entity filter lists in 1.13.2 but was accidentally left in the Data Products-specific filter configuration in DataProduct.constants.ts, causing it to still appear in the Data Products filter panel.

Screenshot 2026-08-18 at 5 57 41 PM

Test plan

  • Navigate to Data Products explore/listing page

Fixes #31701

Greptile Summary

Removes the obsolete Lifecycle Stage option from Data Product filters, aligning this listing with the general entity-filter behavior.

  • Removes Lifecycle Stage from the default quick-filter keys.
  • Removes the corresponding Lifecycle Stage filter descriptor.

Confidence Score: 5/5

The PR appears safe to merge because both Data Product filter configurations remove Lifecycle Stage consistently and no functional regression was identified.

The changed arrays remain aligned across their rendering, URL-state, and query-building consumers, while all other configured filters are preserved.

Important Files Changed

Filename Overview
openmetadata-ui/src/main/resources/ui/src/constants/DataProduct.constants.ts Consistently removes Lifecycle Stage from both Data Product filter configuration arrays without disrupting the remaining filters.

Reviews (1): Last reviewed commit: "Merge branch 'main' into fix/remove-life..." | Re-trigger Greptile

Lifecycle Stage filter was removed from general entity filters in 1.13.2
but was accidentally left in the Data Products-specific filter lists.
Removes it from both DATAPRODUCT_DEFAULT_QUICK_FILTERS and DATAPRODUCT_FILTERS.

Fixes #31701

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

✅ PR checks passed

The linked issue has a description and all required Shipping project fields set. Thanks!

@github-actions github-actions Bot added the UI UI specific issues label Aug 18, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@anuj-kumary anuj-kumary self-assigned this Aug 18, 2026
@anuj-kumary anuj-kumary added the safe to test Add this label to run secure Github workflows on PRs label Aug 18, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 66%
66.85% (79937/119565) 51.25% (48779/95164) 52.24% (14612/27967)

@sonarqubecloud

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown
Contributor

✅ Playwright Results — workflow succeeded

Validated commit 303baf95c1843f9604537b97dee0ee651cc55419 in Playwright run 32136516328, attempt 1.

✅ 551 passed · ❌ 0 failed · 🟡 0 flaky · ⏭️ 0 skipped · 🧰 0 lifecycle flaky

Performance

Blocking targets: ✅ met · Optimization targets: 🟡 in progress

Shard-job maxima below are not the full workflow wall time; the linked run includes build, fixture, planning, and reporting.

🕒 Full workflow signal wall (to summary) 53m 55s

⏱️ Max setup 3m 0s · max shard execution 17m 35s · max shard-job elapsed before upload 20m 53s · reporting 4s

🌐 217.19 requests/attempt · 2.83 app boots/UI scenario · 12.89% common-shard skew

Optimization targets still in progress:

  • Browser traffic was 217.19 requests per attempt (convergence target: fewer than 200).
  • Application boot ratio was 2.83 per UI scenario (1618 boots / 572 scenarios; convergence target: at most 1).
Shard Passed Failed Flaky Skipped Lifecycle failed Lifecycle flaky
✅ Shard chromium-01 145 0 0 0 0 0
✅ Shard chromium-02 129 0 0 0 0 0
✅ Shard chromium-03 125 0 0 0 0 0
✅ Shard data-asset-rules-01 61 0 0 0 0 0
✅ Shard domain-isolation-01 14 0 0 0 0 0
✅ Shard global-state-01 34 0 0 0 0 0
✅ Shard ingestion-01 1 0 0 0 0 0
✅ Shard reindex-01 2 0 0 0 0 0
✅ Shard search-01 11 0 0 0 0 0
✅ Shard search-rbac-01 29 0 0 0 0 0

📦 Download artifacts

How to debug locally
# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip    # view trace

@anuj-kumary
anuj-kumary added this pull request to the merge queue Aug 18, 2026
Merged via the queue into main with commit 0cb1103 Aug 19, 2026
90 of 92 checks passed
@anuj-kumary
anuj-kumary deleted the fix/remove-lifecycle-stage-data-products-filter branch August 19, 2026 11:51
@gitar-bot

gitar-bot Bot commented Aug 19, 2026

Copy link
Copy Markdown
Code Review ✅ Approved

Removes the obsolete Lifecycle Stage option from the Data Product filter configuration to align with general entity filter behavior. No issues found.

Options

Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Powered by Gitar — free for open source

anuj-kumary added a commit that referenced this pull request Aug 19, 2026
…#31703)

Lifecycle Stage filter was removed from general entity filters in 1.13.2
but was accidentally left in the Data Products-specific filter lists.
Removes it from both DATAPRODUCT_DEFAULT_QUICK_FILTERS and DATAPRODUCT_FILTERS.

Fixes #31701

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
(cherry picked from commit 0cb1103)
anuj-kumary added a commit that referenced this pull request Aug 19, 2026
…#31703)

Lifecycle Stage filter was removed from general entity filters in 1.13.2
but was accidentally left in the Data Products-specific filter lists.
Removes it from both DATAPRODUCT_DEFAULT_QUICK_FILTERS and DATAPRODUCT_FILTERS.

Fixes #31701

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
(cherry picked from commit 0cb1103)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs UI UI specific issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Lifecycle Stage visible in Data Products filters

3 participants