Fixes #31607: refresh Explore visual regression baseline - #31686
Conversation
❌ PR checklist incompleteThis PR cannot be merged until the following are addressed on its linked issue:
The fields live on the linked issue in the Shipping project (open the issue → right sidebar → Projects). After you set them, re-run this check (or push a commit) — issue/project changes do not re-trigger it automatically. Maintainers can bypass this check by adding the |
✅ Playwright Results — workflow succeededValidated commit ✅ 551 passed · ❌ 0 failed · 🟡 0 flaky · ⏭️ 0 skipped · 🧰 0 lifecycle flaky PerformanceBlocking targets: ✅ met · Optimization targets: 🟡 in progress Shard-job maxima below are not the full workflow wall time; the linked run includes build, fixture, planning, and reporting. 🕒 Full workflow signal wall (to summary) 2h 6m 9s ⏱️ Max setup 3m 2s · max shard execution 18m 22s · max shard-job elapsed before upload 22m 9s · reporting 4s 🌐 217.13 requests/attempt · 2.83 app boots/UI scenario · 12.34% common-shard skew Optimization targets still in progress:
How to debug locally# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip # view trace |
Code Review ✅ ApprovedRefreshes the Explore visual regression baseline snapshot to align with recent header, filter, typography, and entity-icon updates merged into main. No issues found. OptionsDisplay: compact → Showing less information. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Powered by Gitar — free for open source |
Describe your changes:
Fixes #31607
Refresh the Explore visual regression baseline to match the intentional header, filter, typography, and entity-icon updates already merged into
main. The prior baseline predated those changes and caused unrelated pull requests to fail the visual suite with a deterministic 2% image difference.Type of change:
High-level design:
N/A — this updates one existing visual-regression snapshot without changing application behavior or test thresholds.
Tests:
Use cases covered
Unit tests
Backend integration tests
Ingestion integration tests
Playwright (UI) tests
explore matches baselinesnapshot.Manual testing performed
git diff --check.UI screen recording / screenshots:
Not applicable — this PR does not change runtime UI behavior; it records the UI already merged into
main.Checklist:
Fixes <issue-number>: <short explanation>.Fixes #<issue-number>above.