Skip to content

Fixes #31607: refresh Explore visual regression baseline - #31686

Merged
shah-harshit merged 2 commits into
mainfrom
diagnose-pr-31650-failure
Aug 19, 2026
Merged

Fixes #31607: refresh Explore visual regression baseline#31686
shah-harshit merged 2 commits into
mainfrom
diagnose-pr-31650-failure

Conversation

@shah-harshit

Copy link
Copy Markdown
Contributor

Describe your changes:

Fixes #31607

Refresh the Explore visual regression baseline to match the intentional header, filter, typography, and entity-icon updates already merged into main. The prior baseline predated those changes and caused unrelated pull requests to fail the visual suite with a deterministic 2% image difference.

Type of change:

  • Bug fix

High-level design:

N/A — this updates one existing visual-regression snapshot without changing application behavior or test thresholds.

Tests:

Use cases covered

  • The Explore visual regression baseline represents the current intentional UI.
  • Unrelated pull requests no longer compare the current Explore page against the obsolete pre-change screenshot.

Unit tests

  • Not applicable; no production logic changed.

Backend integration tests

  • Not applicable (no backend API changes).

Ingestion integration tests

  • Not applicable (no ingestion changes).

Playwright (UI) tests

  • Updated the existing explore matches baseline snapshot.
  • Confirmed both CI retry captures are 1440x900 and differ by only 111 pixels, well within the configured 1% tolerance.

Manual testing performed

  1. Inspected the expected, actual, and diff images from the failing visual-regression job.
  2. Confirmed the replacement snapshot matches the stable Playwright 1.57.0 Jammy render.
  3. Ran git diff --check.

UI screen recording / screenshots:

Not applicable — this PR does not change runtime UI behavior; it records the UI already merged into main.

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>.
  • My PR is linked to a GitHub issue via Fixes #<issue-number> above.
  • No explanatory code comments are needed for this binary snapshot update.
  • JSON Schema migration changes are not applicable.
  • UI recording is not applicable because application behavior is unchanged.
  • The existing Playwright visual regression test covers this update.

@github-actions

Copy link
Copy Markdown
Contributor

❌ PR checklist incomplete

This PR cannot be merged until the following are addressed on its linked issue:

The fields live on the linked issue in the Shipping project (open the issue → right sidebar → Projects). After you set them, re-run this check (or push a commit) — issue/project changes do not re-trigger it automatically.

Maintainers can bypass this check by adding the skip-pr-checks label.

@github-actions

github-actions Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

✅ Playwright Results — workflow succeeded

Validated commit 0647db224f40da48f56812440dedc7c707444bee in Playwright run 32128194081, attempt 2.

✅ 551 passed · ❌ 0 failed · 🟡 0 flaky · ⏭️ 0 skipped · 🧰 0 lifecycle flaky

Performance

Blocking targets: ✅ met · Optimization targets: 🟡 in progress

Shard-job maxima below are not the full workflow wall time; the linked run includes build, fixture, planning, and reporting.

🕒 Full workflow signal wall (to summary) 2h 6m 9s

⏱️ Max setup 3m 2s · max shard execution 18m 22s · max shard-job elapsed before upload 22m 9s · reporting 4s

🌐 217.13 requests/attempt · 2.83 app boots/UI scenario · 12.34% common-shard skew

Optimization targets still in progress:

  • Browser traffic was 217.13 requests per attempt (convergence target: fewer than 200).
  • Application boot ratio was 2.83 per UI scenario (1619 boots / 572 scenarios; convergence target: at most 1).
Shard Passed Failed Flaky Skipped Lifecycle failed Lifecycle flaky
✅ Shard chromium-01 142 0 0 0 0 0
✅ Shard chromium-02 133 0 0 0 0 0
✅ Shard chromium-03 124 0 0 0 0 0
✅ Shard data-asset-rules-01 61 0 0 0 0 0
✅ Shard domain-isolation-01 14 0 0 0 0 0
✅ Shard global-state-01 34 0 0 0 0 0
✅ Shard ingestion-01 1 0 0 0 0 0
✅ Shard reindex-01 2 0 0 0 0 0
✅ Shard search-01 11 0 0 0 0 0
✅ Shard search-rbac-01 29 0 0 0 0 0

📦 Download artifacts

How to debug locally
# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip    # view trace

@shah-harshit
shah-harshit added this pull request to the merge queue Aug 18, 2026
Merged via the queue into main with commit 65fde7c Aug 19, 2026
91 of 95 checks passed
@shah-harshit
shah-harshit deleted the diagnose-pr-31650-failure branch August 19, 2026 11:38
@gitar-bot

gitar-bot Bot commented Aug 19, 2026

Copy link
Copy Markdown
Code Review ✅ Approved

Refreshes the Explore visual regression baseline snapshot to align with recent header, filter, typography, and entity-icon updates merged into main. No issues found.

Options

Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Powered by Gitar — free for open source

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs skip-pr-checks Bypass PR metadata validation check UI UI specific issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix Explore header styling and filter hover states

2 participants