Skip to content

fix(ui): Update the widget images in persona modal - #31673

Merged
Rohit0301 merged 5 commits into
mainfrom
widget-images
Aug 19, 2026
Merged

fix(ui): Update the widget images in persona modal#31673
Rohit0301 merged 5 commits into
mainfrom
widget-images

Conversation

@Rohit0301

@Rohit0301 Rohit0301 commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Describe your changes:

Screen.Recording.2026-08-17.at.10.22.31.PM.mov

Fixes #

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

High-level design:

N/A — small change.

Tests:

Use cases covered

Unit tests

Backend integration tests

Ingestion integration tests

Playwright (UI) tests

Manual testing performed

UI screen recording / screenshots:

Not applicable.

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • My PR is linked to a GitHub issue via Fixes #<issue-number> above.
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.
  • For UI changes: I attached a screen recording and/or screenshots above.
  • I have added tests (unit / integration / Playwright as applicable) and listed them above.

Summary by Gitar

  • UI & Widgets:
    • Removed the size prop from widget image utility functions and components.
    • Updated widget image asset imports and paths for customizable landing pages.

This will update automatically on new commits.

Greptile Summary

The PR refreshes widget preview images used by the landing-page customization and persona flows.

  • Consolidates landing-page preview assets under the widgets image directory.
  • Replaces the Knowledge Center preview with the Context Center image.
  • Simplifies landing-page image lookup by removing size-based image selection.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename Overview
openmetadata-ui/src/main/resources/ui/src/utils/CustomizeMyDataPageImageUtils.ts Updates widget preview imports and makes landing-page image lookup independent of widget size.
openmetadata-ui/src/main/resources/ui/src/utils/CustomizeMyDataPageClassBase.ts Updates the public image-lookup wrapper to match the size-independent utility.
openmetadata-ui/src/main/resources/ui/src/components/MyData/CustomizableComponents/AddWidgetModal/AddWidgetTabContent.tsx Updates the landing-page add-widget flow to use the simplified image lookup.
openmetadata-ui/src/main/resources/ui/src/components/MyData/CustomizableComponents/WidgetCard/WidgetCard.tsx Updates widget cards to request landing-page preview images without a size argument.
openmetadata-ui/src/main/resources/ui/src/utils/CustomizeDetailPage/CustomizeDetailPageClassBase.ts Switches the knowledge-article preview import to the new Context Center asset.

Reviews (4): Last reviewed commit: "updated images" | Re-trigger Greptile

@Rohit0301 Rohit0301 self-assigned this Aug 18, 2026
@Rohit0301 Rohit0301 added the safe to test Add this label to run secure Github workflows on PRs label Aug 18, 2026
@github-actions

Copy link
Copy Markdown
Contributor

❌ PR checklist incomplete

This PR cannot be merged until the following are addressed on its linked issue:

  • No GitHub issue is linked. Link an issue in the Development section of the PR (or add Fixes #12345 to the description). For a same-org cross-repo issue, add Fixes open-metadata/<repo>#123 to the description.

The fields live on the linked issue in the Shipping project (open the issue → right sidebar → Projects). After you set them, re-run this check (or push a commit) — issue/project changes do not re-trigger it automatically.

Maintainers can bypass this check by adding the skip-pr-checks label.

@github-actions github-actions Bot added the UI UI specific issues label Aug 18, 2026
@Rohit0301 Rohit0301 changed the title Widget images fix(ui): Update the widget images in persona modal Aug 18, 2026
@github-actions

github-actions Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

⚠️ UI Checkstyle passed — lint findings in changed files

🔍 ESLint findings in this PR's files — 0 error(s), 7 warning(s)

Errors block the build. Warnings do not yet — they are rules whose backlog is still
being worked down, listed so this PR does not add to it. See docs/ui-code-quality-gate.md.

0 error(s), 7 warning(s) across 5 changed file(s).

Count Rule
4 sonarjs/cyclomatic-complexity
3 openmetadata-imports/no-lower-layer-page-imports
All findings
Location Rule Message
🟡 src/components/MyData/CustomizableComponents/AddWidgetModal/AddWidgetTabContent.tsx:29:1 openmetadata-imports/no-lower-layer-page-imports Pages are route-level composition modules. Move the shared implementation/type to a lower layer instead of importing a page from here.
🟡 src/components/MyData/CustomizableComponents/WidgetCard/WidgetCard.tsx:21:1 openmetadata-imports/no-lower-layer-page-imports Pages are route-level composition modules. Move the shared implementation/type to a lower layer instead of importing a page from here.
🟡 src/utils/CustomizeDetailPage/CustomizeDetailPageClassBase.ts:57:10 sonarjs/cyclomatic-complexity {"message":"Function has a complexity of 12 which is greater than 10 authorized.","cost":2,"secondaryLocations":[{"line":57,"column":9,"endLine":57,"endColumn":
🟡 src/utils/CustomizeDetailPage/CustomizeDetailPageClassBase.ts:91:10 sonarjs/cyclomatic-complexity {"message":"Function has a complexity of 28 which is greater than 10 authorized.","cost":18,"secondaryLocations":[{"line":91,"column":9,"endLine":91,"endColumn"
🟡 src/utils/CustomizeMyDataPageClassBase.ts:31:1 openmetadata-imports/no-lower-layer-page-imports Pages are route-level composition modules. Move the shared implementation/type to a lower layer instead of importing a page from here.
🟡 src/utils/CustomizeMyDataPageClassBase.ts:110:10 sonarjs/cyclomatic-complexity {"message":"Function has a complexity of 13 which is greater than 10 authorized.","cost":3,"secondaryLocations":[{"line":110,"column":9,"endLine":110,"endColumn
🟡 src/utils/CustomizeMyDataPageImageUtils.ts:31:72 sonarjs/cyclomatic-complexity {"message":"Function has a complexity of 13 which is greater than 10 authorized.","cost":3,"secondaryLocations":[{"line":31,"column":71,"endLine":31,"endColumn"

Fix locally (fast - only checks files changed in this branch):

make ui-checkstyle-changed

@github-actions

Copy link
Copy Markdown
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 66%
66.86% (79919/119528) 51.26% (48773/95143) 52.24% (14609/27961)

@github-actions

github-actions Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

✅ Playwright Results — workflow succeeded

Validated commit 227adc92ffd399e36212f7f645d10d94d98c575a in Playwright run 32124373316, attempt 1.

✅ 594 passed · ❌ 0 failed · 🟡 0 flaky · ⏭️ 0 skipped · 🧰 0 lifecycle flaky

Performance

Blocking targets: ✅ met · Optimization targets: 🟡 in progress

Shard-job maxima below are not the full workflow wall time; the linked run includes build, fixture, planning, and reporting.

🕒 Full workflow signal wall (to summary) 50m 17s

⏱️ Max setup 4m 1s · max shard execution 15m 59s · max shard-job elapsed before upload 19m 40s · reporting 5s

🌐 220.93 requests/attempt · 2.89 app boots/UI scenario · 13.87% common-shard skew

Optimization targets still in progress:

  • Browser traffic was 220.93 requests per attempt (convergence target: fewer than 200).
  • Application boot ratio was 2.89 per UI scenario (1791 boots / 619 scenarios; convergence target: at most 1).
Shard Passed Failed Flaky Skipped Lifecycle failed Lifecycle flaky
✅ Shard chromium-01 115 0 0 0 0 0
✅ Shard chromium-02 111 0 0 0 0 0
✅ Shard chromium-03 102 0 0 0 0 0
✅ Shard chromium-04 114 0 0 0 0 0
✅ Shard data-asset-rules-01 61 0 0 0 0 0
✅ Shard domain-isolation-01 14 0 0 0 0 0
✅ Shard global-state-01 34 0 0 0 0 0
✅ Shard ingestion-01 1 0 0 0 0 0
✅ Shard reindex-01 2 0 0 0 0 0
✅ Shard search-01 11 0 0 0 0 0
✅ Shard search-rbac-01 29 0 0 0 0 0

📦 Download artifacts

How to debug locally
# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip    # view trace

@sonarqubecloud

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown
Contributor

🚦 Removed from the merge queue — failed_checks (2026-08-19T03:47:20Z)

Blocked the queue: playwright-summary

@Rohit0301
Rohit0301 added this pull request to the merge queue Aug 19, 2026
Merged via the queue into main with commit 2956f71 Aug 19, 2026
94 of 98 checks passed
@Rohit0301
Rohit0301 deleted the widget-images branch August 19, 2026 12:38
@gitar-bot

gitar-bot Bot commented Aug 19, 2026

Copy link
Copy Markdown
Code Review ✅ Approved

Removes the size prop from widget image utilities and updates persona modal widget assets. No issues found.

Options

Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Powered by Gitar — free for open source

Rohit0301 added a commit that referenced this pull request Aug 19, 2026
* fix(ui): Update the widget images in persona modal

* remove the size prop

* lint fix

* updated images
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs UI UI specific issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants