Skip to content

fix metric table width for bigger screen - #31653

Queued
anuj-kumary wants to merge 2 commits into
mainfrom
metric-table
Queued

fix metric table width for bigger screen#31653
anuj-kumary wants to merge 2 commits into
mainfrom
metric-table

Conversation

@anuj-kumary

@anuj-kumary anuj-kumary commented Aug 17, 2026

Copy link
Copy Markdown
Member

Describe your changes:

The metrics list table rendered at the summed width of its fixed-width columns, leaving an empty gap on the right side of the card on wide screens.

Screenshot 2026-08-17 at 11 29 32 PM

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

High-level design:

N/A — small change.

Tests:

Use cases covered

Unit tests

Backend integration tests

Ingestion integration tests

Playwright (UI) tests

Manual testing performed

UI screen recording / screenshots:

Not applicable.

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • My PR is linked to a GitHub issue via Fixes #<issue-number> above.
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.
  • For UI changes: I attached a screen recording and/or screenshots above.
  • I have added tests (unit / integration / Playwright as applicable) and listed them above.

Greptile Summary

The PR adds an explicit full-width declaration to the metrics-list table.

  • Sets the nested metrics table width to 100%.
  • Leaves the remainder of the page and table styling unchanged.

Confidence Score: 4/5

The PR does not appear safe to merge because the previously reported ineffective width fix remains outstanding.

The metrics table already receives tw:w-full, so the added declaration supplies the same computed width and leaves the reported wide-screen layout defect unresolved.

Files Needing Attention: openmetadata-ui/src/main/resources/ui/src/pages/MetricsPage/MetricListPage/metric-list-page.less

Important Files Changed

Filename Overview
openmetadata-ui/src/main/resources/ui/src/pages/MetricsPage/MetricListPage/metric-list-page.less Adds a single width: 100% declaration to the metrics-list table rule.

Reviews (2): Last reviewed commit: "Merge branch 'main' into metric-table" | Re-trigger Greptile

@anuj-kumary anuj-kumary self-assigned this Aug 17, 2026
@anuj-kumary anuj-kumary added UI UI specific issues safe to test Add this label to run secure Github workflows on PRs To release Will cherry-pick this PR into the release branch skip-pr-checks Bypass PR metadata validation check labels Aug 17, 2026
@gitar-bot

gitar-bot Bot commented Aug 18, 2026

Copy link
Copy Markdown
Code Review ✅ Approved

Updates the metric table width to prevent empty gaps on wide screens. No issues found.

Options

Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Powered by Gitar — free for open source

@github-actions

Copy link
Copy Markdown
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 66%
66.85% (79930/119552) 51.25% (48765/95142) 52.23% (14607/27963)

@sonarqubecloud

Copy link
Copy Markdown

@github-actions

github-actions Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

✅ Playwright Results — workflow succeeded

Validated commit f2ecfa3a13ab0bc963e0c046f243e4d391abcacd in Playwright run 32094503615, attempt 2.

✅ 551 passed · ❌ 0 failed · 🟡 0 flaky · ⏭️ 0 skipped · 🧰 0 lifecycle flaky

Performance

Blocking targets: ✅ met · Optimization targets: 🟡 in progress

Shard-job maxima below are not the full workflow wall time; the linked run includes build, fixture, planning, and reporting.

🕒 Full workflow signal wall (to summary) 1h 25m 51s

⏱️ Max setup 3m 13s · max shard execution 16m 33s · max shard-job elapsed before upload 22m 22s · reporting 3s

🌐 211.58 requests/attempt · 2.83 app boots/UI scenario · 13.80% common-shard skew

Optimization targets still in progress:

  • Browser traffic was 211.58 requests per attempt (convergence target: fewer than 200).
  • Application boot ratio was 2.83 per UI scenario (1618 boots / 572 scenarios; convergence target: at most 1).
Shard Passed Failed Flaky Skipped Lifecycle failed Lifecycle flaky
✅ Shard chromium-01 107 0 0 0 0 0
✅ Shard chromium-02 96 0 0 0 0 0
✅ Shard chromium-03 96 0 0 0 0 0
✅ Shard chromium-04 100 0 0 0 0 0
✅ Shard data-asset-rules-01 61 0 0 0 0 0
✅ Shard domain-isolation-01 14 0 0 0 0 0
✅ Shard global-state-01 34 0 0 0 0 0
✅ Shard ingestion-01 1 0 0 0 0 0
✅ Shard reindex-01 2 0 0 0 0 0
✅ Shard search-01 11 0 0 0 0 0
✅ Shard search-rbac-01 29 0 0 0 0 0

📦 Download artifacts

How to debug locally
# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip    # view trace

@anuj-kumary
anuj-kumary added this pull request to the merge queue Aug 18, 2026
Any commits made after this event will not be merged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs skip-pr-checks Bypass PR metadata validation check To release Will cherry-pick this PR into the release branch UI UI specific issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants