fix(playwright): Bulk import playwright fix, user tab selection in owner popover - #31652
Conversation
❌ PR checklist incompleteThis PR cannot be merged until the following are addressed on its linked issue:
The fields live on the linked issue in the Shipping project (open the issue → right sidebar → Projects). After you set them, re-run this check (or push a commit) — issue/project changes do not re-trigger it automatically. Maintainers can bypass this check by adding the |
✅ Playwright Results — workflow succeededValidated commit ✅ 551 passed · ❌ 0 failed · 🟡 0 flaky · ⏭️ 0 skipped · 🧰 0 lifecycle flaky PerformanceBlocking targets: ✅ met · Optimization targets: 🟡 in progress Shard-job maxima below are not the full workflow wall time; the linked run includes build, fixture, planning, and reporting. 🕒 Full workflow signal wall (to summary) 55m 34s ⏱️ Max setup 3m 7s · max shard execution 18m 36s · max shard-job elapsed before upload 22m 23s · reporting 5s 🌐 213.91 requests/attempt · 2.83 app boots/UI scenario · 16.22% common-shard skew Optimization targets still in progress:
How to debug locally# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip # view trace |
Code Review ✅ ApprovedFixes Playwright E2E test utilities in importUtils.ts by correcting bulk import functionality and user tab selection in the owner popover. No issues found. OptionsDisplay: compact → Showing less information. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Powered by Gitar — free for open source |
Describe your changes:
Fixes #
I worked on ... because ...
Type of change:
High-level design:
N/A — small change.
Tests:
Use cases covered
Unit tests
Backend integration tests
Ingestion integration tests
Playwright (UI) tests
Manual testing performed
UI screen recording / screenshots:
Not applicable.
Checklist:
Fixes <issue-number>: <short explanation>Fixes #<issue-number>above.Summary by Gitar
importUtils.tsThis will update automatically on new commits.
Greptile Summary
The PR adjusts Playwright synchronization when selecting users in the bulk-import owner popover.
domcontentloadedbefore switching tabs.Confidence Score: 5/5
The PR appears safe to merge with no actionable defects identified.
The changed helper continues to register its response waiter before clicking the Users tab, and the added load-state wait resolves on the already-loaded SPA document used by current callers.
Important Files Changed
Reviews (1): Last reviewed commit: "lint fix" | Re-trigger Greptile