Skip to content

fix(playwright): Bulk import playwright fix, user tab selection in owner popover - #31652

Merged
Rohit0301 merged 2 commits into
mainfrom
bulk-import-fix
Aug 18, 2026
Merged

fix(playwright): Bulk import playwright fix, user tab selection in owner popover#31652
Rohit0301 merged 2 commits into
mainfrom
bulk-import-fix

Conversation

@Rohit0301

@Rohit0301 Rohit0301 commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Describe your changes:

Fixes #

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

High-level design:

N/A — small change.

Tests:

Use cases covered

Unit tests

Backend integration tests

Ingestion integration tests

Playwright (UI) tests

Manual testing performed

UI screen recording / screenshots:

Not applicable.

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • My PR is linked to a GitHub issue via Fixes #<issue-number> above.
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.
  • For UI changes: I attached a screen recording and/or screenshots above.
  • I have added tests (unit / integration / Playwright as applicable) and listed them above.

Summary by Gitar

  • Playwright tests:
    • Fixed bulk import utility and user tab selection in owner popover inside importUtils.ts

This will update automatically on new commits.

Greptile Summary

The PR adjusts Playwright synchronization when selecting users in the bulk-import owner popover.

  • Waits for the current document to reach domcontentloaded before switching tabs.
  • Uses a predicate to recognize the user-search response instead of the previous URL glob.

Confidence Score: 5/5

The PR appears safe to merge with no actionable defects identified.

The changed helper continues to register its response waiter before clicking the Users tab, and the added load-state wait resolves on the already-loaded SPA document used by current callers.

Important Files Changed

Filename Overview
openmetadata-ui/src/main/resources/ui/playwright/utils/importUtils.ts Updates owner-popover test synchronization; no actionable changed-code defect was established.

Reviews (1): Last reviewed commit: "lint fix" | Re-trigger Greptile

@Rohit0301 Rohit0301 self-assigned this Aug 17, 2026
@Rohit0301 Rohit0301 added the safe to test Add this label to run secure Github workflows on PRs label Aug 17, 2026
@github-actions github-actions Bot added the UI UI specific issues label Aug 17, 2026
@github-actions

Copy link
Copy Markdown
Contributor

❌ PR checklist incomplete

This PR cannot be merged until the following are addressed on its linked issue:

  • No GitHub issue is linked. Link an issue in the Development section of the PR (or add Fixes #12345 to the description). For a same-org cross-repo issue, add Fixes open-metadata/<repo>#123 to the description.

The fields live on the linked issue in the Shipping project (open the issue → right sidebar → Projects). After you set them, re-run this check (or push a commit) — issue/project changes do not re-trigger it automatically.

Maintainers can bypass this check by adding the skip-pr-checks label.

@github-actions

Copy link
Copy Markdown
Contributor

✅ Playwright Results — workflow succeeded

Validated commit e208a0365b2898568bda976dd6f5f038992d3ec3 in Playwright run 32051766840, attempt 1.

✅ 551 passed · ❌ 0 failed · 🟡 0 flaky · ⏭️ 0 skipped · 🧰 0 lifecycle flaky

Performance

Blocking targets: ✅ met · Optimization targets: 🟡 in progress

Shard-job maxima below are not the full workflow wall time; the linked run includes build, fixture, planning, and reporting.

🕒 Full workflow signal wall (to summary) 55m 34s

⏱️ Max setup 3m 7s · max shard execution 18m 36s · max shard-job elapsed before upload 22m 23s · reporting 5s

🌐 213.91 requests/attempt · 2.83 app boots/UI scenario · 16.22% common-shard skew

Optimization targets still in progress:

  • Common shard skew was 16.22% (convergence target: at most 15%).
  • Browser traffic was 213.91 requests per attempt (convergence target: fewer than 200).
  • Application boot ratio was 2.83 per UI scenario (1619 boots / 572 scenarios; convergence target: at most 1).
Shard Passed Failed Flaky Skipped Lifecycle failed Lifecycle flaky
✅ Shard chromium-01 142 0 0 0 0 0
✅ Shard chromium-02 133 0 0 0 0 0
✅ Shard chromium-03 124 0 0 0 0 0
✅ Shard data-asset-rules-01 61 0 0 0 0 0
✅ Shard domain-isolation-01 14 0 0 0 0 0
✅ Shard global-state-01 34 0 0 0 0 0
✅ Shard ingestion-01 1 0 0 0 0 0
✅ Shard reindex-01 2 0 0 0 0 0
✅ Shard search-01 11 0 0 0 0 0
✅ Shard search-rbac-01 29 0 0 0 0 0

📦 Download artifacts

How to debug locally
# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip    # view trace

@Rohit0301
Rohit0301 added this pull request to the merge queue Aug 18, 2026
Merged via the queue into main with commit 8b1cbf4 Aug 18, 2026
81 of 88 checks passed
@Rohit0301
Rohit0301 deleted the bulk-import-fix branch August 18, 2026 07:33
@gitar-bot

gitar-bot Bot commented Aug 18, 2026

Copy link
Copy Markdown
Code Review ✅ Approved

Fixes Playwright E2E test utilities in importUtils.ts by correcting bulk import functionality and user tab selection in the owner popover. No issues found.

Options

Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Powered by Gitar — free for open source

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs UI UI specific issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants