Skip to content

Fix context center quick link and pagination test - #31646

Merged
Rohit0301 merged 5 commits into
mainfrom
fix-context-center-quick-link-test
Aug 18, 2026
Merged

Fix context center quick link and pagination test#31646
Rohit0301 merged 5 commits into
mainfrom
fix-context-center-quick-link-test

Conversation

@Rohit0301

@Rohit0301 Rohit0301 commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Describe your changes:

Fixes #

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

High-level design:

N/A — small change.

Tests:

Use cases covered

Unit tests

Backend integration tests

Ingestion integration tests

Playwright (UI) tests

Manual testing performed

UI screen recording / screenshots:

Not applicable.

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • My PR is linked to a GitHub issue via Fixes #<issue-number> above.
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.
  • For UI changes: I attached a screen recording and/or screenshots above.
  • I have added tests (unit / integration / Playwright as applicable) and listed them above.

Greptile Summary

The PR updates two Playwright tests to improve synchronization and preserve the Context Center search state.

  • Waits for the actual .ant-skeleton element within the total-data-assets widget to detach.
  • Removes the search-clear and loader-wait steps before updating a Context Center quick link.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename Overview
openmetadata-ui/src/main/resources/ui/playwright/e2e/Features/ContextCenterArticles.spec.ts Keeps the searched quick-link card selected while proceeding to the update flow.
openmetadata-ui/src/main/resources/ui/playwright/e2e/Features/Pagination.spec.ts Correctly replaces the absent active-skeleton selector with the widget’s rendered skeleton selector, resolving the prior synchronization finding.

Reviews (4): Last reviewed commit: "Merge branch 'main' into fix-context-cen..." | Re-trigger Greptile

@Rohit0301 Rohit0301 self-assigned this Aug 17, 2026
@Rohit0301 Rohit0301 added the safe to test Add this label to run secure Github workflows on PRs label Aug 17, 2026
@github-actions

Copy link
Copy Markdown
Contributor

❌ PR checklist incomplete

This PR cannot be merged until the following are addressed on its linked issue:

  • No GitHub issue is linked. Link an issue in the Development section of the PR (or add Fixes #12345 to the description). For a same-org cross-repo issue, add Fixes open-metadata/<repo>#123 to the description.

The fields live on the linked issue in the Shipping project (open the issue → right sidebar → Projects). After you set them, re-run this check (or push a commit) — issue/project changes do not re-trigger it automatically.

Maintainers can bypass this check by adding the skip-pr-checks label.

@github-actions github-actions Bot added the UI UI specific issues label Aug 17, 2026
@github-actions

github-actions Bot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

✅ Playwright Results — workflow succeeded

Validated commit 0ef61579b22d73784c02cacfdd73782119b0ddc2 in Playwright run 32046357543, attempt 1.

✅ 121 passed · ❌ 0 failed · 🟡 0 flaky · ⏭️ 0 skipped · 🧰 0 lifecycle flaky

Performance

Blocking targets: ✅ met · Optimization targets: 🟡 in progress

Shard-job maxima below are not the full workflow wall time; the linked run includes build, fixture, planning, and reporting.

🕒 Full workflow signal wall (to summary) 44m 1s

⏱️ Max setup 1m 38s · max shard execution 9m 43s · max shard-job elapsed before upload 14m 14s · reporting 3s

🌐 159.54 requests/attempt · 1.79 app boots/UI scenario · 0.00% common-shard skew

Optimization targets still in progress:

  • Application boot ratio was 1.79 per UI scenario (244 boots / 136 scenarios; convergence target: at most 1).
Shard Passed Failed Flaky Skipped Lifecycle failed Lifecycle flaky
✅ Shard chromium-01 121 0 0 0 0 0

📦 Download artifacts

How to debug locally
# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip    # view trace

Rohit0301 and others added 2 commits August 17, 2026 20:06
…Pagination.spec.ts

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
@Rohit0301 Rohit0301 changed the title Fix context center quick link test Fix context center quick link and pagination test Aug 17, 2026
@Rohit0301
Rohit0301 enabled auto-merge August 17, 2026 16:56
@Rohit0301
Rohit0301 added this pull request to the merge queue Aug 18, 2026
Merged via the queue into main with commit ff03695 Aug 18, 2026
77 of 80 checks passed
@Rohit0301
Rohit0301 deleted the fix-context-center-quick-link-test branch August 18, 2026 12:21
@gitar-bot

gitar-bot Bot commented Aug 18, 2026

Copy link
Copy Markdown
Code Review ✅ Approved

Updates Playwright end-to-end tests for the context center quick link and pagination to reduce flakiness. No issues found.

Options

Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Powered by Gitar — free for open source

Rohit0301 added a commit that referenced this pull request Aug 18, 2026
* Fixed context center flaky quick link test

* lint fix

* fix pagination test

* Update openmetadata-ui/src/main/resources/ui/playwright/e2e/Features/Pagination.spec.ts

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>

---------

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs UI UI specific issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants