Skip to content

ci: inline free-disk-space in py-tests-shared (test) - #31548

Open
miriann-uu wants to merge 6 commits into
mainfrom
ci-inline-free-disk-space-pytests
Open

ci: inline free-disk-space in py-tests-shared (test)#31548
miriann-uu wants to merge 6 commits into
mainfrom
ci-inline-free-disk-space-pytests

Conversation

@miriann-uu

@miriann-uu miriann-uu commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Test for the flaky CI failure Chirag hit on #31516: jlumbroso/free-disk-space@54081… intermittently fails to download from codeload at setup. This drops the external action and inlines the equivalent (android/dotnet/haskell/swap) as a run: step, so there's no codeload download to flake. Testing on py-tests-shared first to confirm disk reclaim (df -h) and a green shard before rolling to the playwright workflows. cc @chirag @harsh

Greptile Summary

This PR removes the pinned third-party disk-cleanup action from three CI workflows to avoid intermittent action-download failures.

  • Inlines removal of preinstalled Android, .NET, Haskell, and GHCup files.
  • Disables and removes the runner swapfile.
  • Prints filesystem usage after cleanup.

Confidence Score: 5/5

The PR appears safe to merge; no concrete changed-code failure was identified.

The workflows preserve the selected cleanup scope while eliminating the external action download, and no later dependency on the removed toolchains or current runner incompatibility was established.

Important Files Changed

Filename Overview
.github/workflows/playwright-e2e-reusable.yml Replaces the conditional external disk-cleanup action with equivalent inline cleanup commands while preserving the existing condition.
.github/workflows/playwright-visual.yml Replaces the external disk-cleanup action with inline runner cleanup before checkout.
.github/workflows/py-tests-shared.yml Replaces the external disk-cleanup action with inline runner cleanup before checkout.

Reviews (1): Last reviewed commit: "update playwright workflow" | Re-trigger Greptile

@github-actions

Copy link
Copy Markdown
Contributor

❌ PR checklist incomplete

This PR cannot be merged until the following are addressed on its linked issue:

  • No GitHub issue is linked. Link an issue in the Development section of the PR (or add Fixes #12345 to the description). For a same-org cross-repo issue, add Fixes open-metadata/<repo>#123 to the description.

The fields live on the linked issue in the Shipping project (open the issue → right sidebar → Projects). After you set them, re-run this check (or push a commit) — issue/project changes do not re-trigger it automatically.

Maintainers can bypass this check by adding the skip-pr-checks label.

@github-actions

github-actions Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

🔴 Playwright Results — workflow failed

Validated commit e691b5a520c401c0e487a7351301c6bb663cde38 in Playwright run 32223505707, attempt 1.

✅ 0 passed · ❌ 0 failed · 🟡 0 flaky · ⏭️ 0 skipped · 🧰 0 lifecycle flaky

Pipeline and setup failures (22)

  • Seeded fixture preparation finished with status failure.
  • The Playwright shard matrix was unexpectedly skipped.
  • Shard chromium-01 did not upload a usable Playwright results artifact.
  • Shard chromium-02 did not upload a usable Playwright results artifact.
  • Shard chromium-03 did not upload a usable Playwright results artifact.
  • Shard data-asset-rules-01 did not upload a usable Playwright results artifact.
  • Shard domain-isolation-01 did not upload a usable Playwright results artifact.
  • Shard global-state-01 did not upload a usable Playwright results artifact.
  • Shard ingestion-01 did not upload a usable Playwright results artifact.
  • Shard reindex-01 did not upload a usable Playwright results artifact.
  • Shard search-01 did not upload a usable Playwright results artifact.
  • Shard search-rbac-01 did not upload a usable Playwright results artifact.
  • Shard chromium-01 did not upload its execution status.
  • Shard chromium-02 did not upload its execution status.
  • Shard chromium-03 did not upload its execution status.
  • Shard data-asset-rules-01 did not upload its execution status.
  • Shard domain-isolation-01 did not upload its execution status.
  • Shard global-state-01 did not upload its execution status.
  • Shard ingestion-01 did not upload its execution status.
  • Shard reindex-01 did not upload its execution status.
  • Shard search-01 did not upload its execution status.
  • Shard search-rbac-01 did not upload its execution status.

Performance

⚪ Performance metrics unavailable; see the CI and reporting failures above.

Shard Passed Failed Flaky Skipped Lifecycle failed Lifecycle flaky
⛔ Shard chromium-01
⛔ Shard chromium-02
⛔ Shard chromium-03
⛔ Shard data-asset-rules-01
⛔ Shard domain-isolation-01
⛔ Shard global-state-01
⛔ Shard ingestion-01
⛔ Shard reindex-01
⛔ Shard search-01
⛔ Shard search-rbac-01

📦 Download artifacts

How to debug locally
# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip    # view trace

Comment thread .github/workflows/zz-test-inline-free-disk.yml Fixed
chirag-madlani
chirag-madlani previously approved these changes Aug 14, 2026
chirag-madlani
chirag-madlani previously approved these changes Aug 14, 2026
@sonarqubecloud

Copy link
Copy Markdown

@miriann-uu
miriann-uu added this pull request to the merge queue Aug 14, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Aug 14, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🚦 Removed from the merge queue — failed_checks (2026-08-14T20:48:28Z)

Blocked the queue: playwright-summary

@miriann-uu
miriann-uu added this pull request to the merge queue Aug 17, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Aug 17, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🚦 Removed from the merge queue — failed_checks (2026-08-17T16:05:19Z)

Blocked the queue: py-tests-status, java-checkstyle

@chirag-madlani
chirag-madlani added this pull request to the merge queue Aug 18, 2026
@chirag-madlani
chirag-madlani removed this pull request from the merge queue due to a manual request Aug 19, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🚦 Removed from the merge queue — manual (2026-08-19T06:21:14Z)

The entry left the queue before it was built, so no checks ran against it.

@gitar-bot

gitar-bot Bot commented Aug 19, 2026

Copy link
Copy Markdown
Code Review ✅ Approved

Inlines disk-space cleanup steps in CI workflows to eliminate flaky codeload action downloads. No issues found.

Options

Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Powered by Gitar — free for open source

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

devops safe to test Add this label to run secure Github workflows on PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants