test: fix flaky event handler test#609
Open
gruebel wants to merge 1 commit into
Open
Conversation
Signed-off-by: gruebel <anton.gruebel@gmail.com>
There was a problem hiding this comment.
Code Review
This pull request refactors a test in tests/test_client.py to use separate threading events and wrapper functions for tracking the execution of raising and recording handlers. The reviewer suggests a cleaner approach by leveraging the side_effect parameter of MagicMock to trigger the threading events directly, which eliminates the need for the verbose wrapper functions.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #609 +/- ##
=======================================
Coverage 98.34% 98.34%
=======================================
Files 45 45
Lines 2477 2483 +6
=======================================
+ Hits 2436 2442 +6
Misses 41 41
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR