-
Notifications
You must be signed in to change notification settings - Fork 31
feat: make use of flagd-selector header in RPC mode #396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
dc0488a
feat(flagd): send flagd-selector header on RPC calls
toddbaert 2f8a795
refactor(flagd): precompute selector metadata and extract stream call…
toddbaert c03c838
fix(flagd): bump grpcio>=1.81.0 to match generated stubs
toddbaert 7ca797b
fix(flagd): widen metadata TypedDict and cover EventStream selector
toddbaert 3060ce2
fix(flagd): use contextlib.suppress to satisfy ruff S110/SIM105
toddbaert 962ce84
Update providers/openfeature-provider-flagd/src/openfeature/contrib/p…
toddbaert b187b10
style(flagd): apply ruff format to selector_metadata expression
toddbaert File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
79 changes: 79 additions & 0 deletions
79
providers/openfeature-provider-flagd/tests/test_grpc_resolver.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,79 @@ | ||
| from contextlib import suppress | ||
| from unittest.mock import MagicMock, Mock | ||
|
|
||
| from openfeature.contrib.provider.flagd.config import Config | ||
| from openfeature.contrib.provider.flagd.flag_type import FlagType | ||
| from openfeature.contrib.provider.flagd.resolvers.grpc import ( | ||
| FLAGD_SELECTOR_HEADER, | ||
| GrpcResolver, | ||
| ) | ||
| from openfeature.schemas.protobuf.flagd.evaluation.v2 import evaluation_pb2 | ||
|
toddbaert marked this conversation as resolved.
|
||
|
|
||
|
|
||
| def _make_resolver(selector): | ||
| config = Config(host="localhost", port=8013, tls=False) | ||
| config.selector = selector | ||
| resolver = GrpcResolver( | ||
| config=config, | ||
| emit_provider_ready=Mock(), | ||
| emit_provider_error=Mock(), | ||
| emit_provider_stale=Mock(), | ||
| emit_provider_configuration_changed=Mock(), | ||
| ) | ||
| return resolver | ||
|
|
||
|
|
||
| def test_unary_call_includes_selector_metadata_when_configured(): | ||
| resolver = _make_resolver("test-selector") | ||
| mock_stub = MagicMock() | ||
| mock_stub.ResolveBoolean = Mock( | ||
| return_value=evaluation_pb2.ResolveBooleanResponse(value=True, reason="STATIC") | ||
| ) | ||
| resolver.stub = mock_stub | ||
|
|
||
| resolver._resolve("flag", FlagType.BOOLEAN, False, None) | ||
|
|
||
| kwargs = mock_stub.ResolveBoolean.call_args.kwargs | ||
| assert kwargs.get("metadata") == ((FLAGD_SELECTOR_HEADER, "test-selector"),) | ||
|
|
||
|
|
||
| def test_unary_call_omits_metadata_when_no_selector(): | ||
| resolver = _make_resolver(None) | ||
| mock_stub = MagicMock() | ||
| mock_stub.ResolveBoolean = Mock( | ||
| return_value=evaluation_pb2.ResolveBooleanResponse(value=True, reason="STATIC") | ||
| ) | ||
| resolver.stub = mock_stub | ||
|
|
||
| resolver._resolve("flag", FlagType.BOOLEAN, False, None) | ||
|
|
||
| kwargs = mock_stub.ResolveBoolean.call_args.kwargs | ||
| assert "metadata" not in kwargs | ||
|
toddbaert marked this conversation as resolved.
|
||
|
|
||
|
|
||
| def test_event_stream_includes_selector_metadata_when_configured(): | ||
| resolver = _make_resolver("test-selector") | ||
| mock_stub = MagicMock() | ||
| mock_stub.EventStream = Mock(side_effect=Exception("break loop")) | ||
| resolver.stub = mock_stub | ||
| resolver.active = True | ||
|
|
||
| with suppress(Exception): | ||
| resolver.listen() | ||
|
|
||
| kwargs = mock_stub.EventStream.call_args.kwargs | ||
| assert kwargs.get("metadata") == ((FLAGD_SELECTOR_HEADER, "test-selector"),) | ||
|
|
||
|
|
||
| def test_event_stream_omits_metadata_when_no_selector(): | ||
| resolver = _make_resolver(None) | ||
| mock_stub = MagicMock() | ||
| mock_stub.EventStream = Mock(side_effect=Exception("break loop")) | ||
| resolver.stub = mock_stub | ||
| resolver.active = True | ||
|
|
||
| with suppress(Exception): | ||
| resolver.listen() | ||
|
|
||
| kwargs = mock_stub.EventStream.call_args.kwargs | ||
| assert "metadata" not in kwargs | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.