Skip to content

feat!: DISABLED is a successful evaluation (still defaults) #395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
toddbaert merged 7 commits into from
Jun 2, 2026
Merged

feat!: DISABLED is a successful evaluation (still defaults) #395

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b725831
feat(flagd-core): add disabled flag evaluation e2e BDD scenarios
jonathannorris May 25, 2026
6acf7e9
chore: bump flagd-testbed submodule to v3.8.0
toddbaert Jun 1, 2026
f1a5d1d
feat(flagd): RPC resolver substitutes caller default on reason=DISABLED
toddbaert Jun 1, 2026
91ee54e
fix(flagd): RPC Object resolver tolerates missing value field
toddbaert Jun 1, 2026
e439b30
style(flagd): apply ruff format to DISABLED guard
toddbaert Jun 1, 2026
7b75ac8
chore(flagd-core): drop redundant disabled.feature and test_disabled.py
toddbaert Jun 1, 2026
ae05cac
Apply suggestion from @toddbaert
toddbaert Jun 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion providers/openfeature-provider-flagd/openfeature/test-harness
Open in desktop
Submodule test-harness updated 10 files
+1 −1 .release-please-manifest.json
+7 −0 CHANGELOG.md
+1 −1 docker-compose.yaml
+44 −0 evaluator/flags/testkit-flags.json
+22 −0 evaluator/gherkin/disabled.feature
+1 −1 flagd/Dockerfile
+56 −0 flags/disabled-flags.json
+11 −0 flags/selector-flags.json
+37 −0 gherkin/disabled.feature
+1 −1 version.txt
15 changes: 10 additions & 5 deletions ...iders/openfeature-provider-flagd/src/openfeature/contrib/provider/flagd/resolvers/grpc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -409,9 +409,10 @@ def _resolve( # noqa: PLR0915 C901
flag_key=flag_key, context=context
)
response = self.stub.ResolveObject(request, **call_args)
value = MessageToDict(response, preserving_proto_field_name=True)[
"value"
]
# DISABLED responses omit the value field entirely; fall back to default_value
value = MessageToDict(response, preserving_proto_field_name=True).get(
"value", default_value
)
elif flag_type == FlagType.FLOAT:
request = evaluation_pb2.ResolveFloatRequest(
flag_key=flag_key, context=context
Expand Down Expand Up @@ -443,8 +444,12 @@ def _resolve( # noqa: PLR0915 C901
raise GeneralError(message) from e

# When no default variant is configured, the server returns an empty/zero proto
# value with reason=DEFAULT. In that case, return the caller's code default value.
if response.reason == Reason.DEFAULT and not response.variant:
# value with reason=DEFAULT. For DISABLED flags the server omits the variant too.
# In both cases, return the caller's code default value.
if (
response.reason in (Reason.DEFAULT, Reason.DISABLED)
and not response.variant
):
value = default_value

# Got a valid flag and valid type. Return it.
Expand Down
Loading