chore: fix: finalize was missing from the octx context#799
Open
Skarlso wants to merge 11 commits into
Open
Conversation
2 tasks
Skarlso
force-pushed
the
memory-leak-investigation
branch
from
December 11, 2025 08:23
2314f90 to
02c6a3b
Compare
frewilhelm
previously approved these changes
Dec 11, 2025
morri-son
previously approved these changes
Jan 26, 2026
Skarlso
changed the title
Skarlso
changed the title
Skarlso
marked this pull request as draft
February 2, 2026 11:17
Skarlso
force-pushed
the
memory-leak-investigation
branch
from
April 14, 2026 06:53
e1d5ff3 to
d7e20af
Compare
Skarlso
force-pushed
the
memory-leak-investigation
branch
from
June 1, 2026 08:15
c1eece8 to
6690057
Compare
On-behalf-of: Gergely Brautigam <gergely.brautigam@sap.com> Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
On-behalf-of: Gergely Brautigam <gergely.brautigam@sap.com> Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
On-behalf-of: Gergely Brautigam <gergely.brautigam@sap.com> Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
On-behalf-of: Gergely Brautigam <gergely.brautigam@sap.com> Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
On-behalf-of: Gergely Brautigam <gergely.brautigam@sap.com> Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
Skarlso
force-pushed
the
memory-leak-investigation
branch
from
June 24, 2026 07:27
6690057 to
ae1f5ab
Compare
Skarlso
changed the title
Skarlso
marked this pull request as ready for review
June 25, 2026 08:28
Skarlso
commented
Jun 26, 2026
On-behalf-of: Gergely Brautigam <gergely.brautigam@sap.com> Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
Signed-off-by: Gergely Bräutigam <gergely.brautigam@sap.com>
Skarlso
force-pushed
the
memory-leak-investigation
branch
from
July 17, 2026 08:43
e4a102f to
142fc2c
Compare
frewilhelm
reviewed
Jul 17, 2026
frewilhelm
left a comment
frewilhelm
left a comment
Contributor
There was a problem hiding this comment.
i think the PR desc could get a bit more love :D
Comment on lines
+83
to
+88
| flag.StringVar( | ||
| &pprofAddr, | ||
| "pprof-bind-address", | ||
| "", | ||
| "The address the pprof endpoint binds to. Disabled if empty.", | ||
| ) |
Contributor
There was a problem hiding this comment.
do you want to leave that in?
Contributor
Author
There was a problem hiding this comment.
I would like to, yeah. It's optional. 🤔 and honestly, I'm debating to do something similar on k8s-toolkit. But akin to Kro's approach here: https://github.com/kubernetes-sigs/kro/blob/main/cmd/controller/pprof.go
Contributor
Author
There was a problem hiding this comment.
Uses a build flag instead of a command line argument https://github.com/kubernetes-sigs/kro/blob/main/cmd/controller/pprof_disabled.go.
Contributor
Author
There was a problem hiding this comment.
Changed to Kro's approach. :)
Contributor
Author
But I'm already loving it... a LOT :D |
Co-authored-by: Frederic Wilhelm <fre.wilhelm@gmail.com> Signed-off-by: Gergely Bräutigam <skarlso777@gmail.com>
Contributor
Author
|
Will update the description as well in a sec. :) |
On-behalf-of: Gergely Brautigam <gergely.brautigam@sap.com> Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Testable
ghcr.io/open-component-model/ocm-controller:v0.28.0-memory-leak-test-1Closes open-component-model/ocm-project#778.
Which issue(s) this PR is related to