Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add the pure, advisory-only contract for evaluating code-review finding utility. This foundation defines typed state and question schemas, deterministic fail-safe policy behavior, canonical provenance, duplicate handling, and verifiable audit records without connecting the feature to the review pipeline.
Changes
effective_decision: keepfor every advisory recordTesting
go test ./internal/findingutility -count=1go test -race ./internal/findingutility -count=1jqgo build ./cmd/crgit diff --checkThe full repository test run reached the existing installed-Pi integration test and failed because the host selected Node 18, while the installed Pi bundle imports
node:fs.globSync. The package under this PR and the remaining Go packages passed. Repository lint also could not type-check Go 1.27's standard-librarymath/rand/v2with the installed linter.Scope limits
This PR does not add a provider transport, network or credential access, calibrated thresholds, production suppression, pipeline integration, CLI flags, ledger changes, or a development binary. Exported runtime policy remains non-applying; only private test helpers exercise suppression signatures.