fix: harden runtime defaults and simplify init editors - #612
Merged
Merged
Conversation
There was a problem hiding this comment.
Automated PR Review
Reviewed commit: 226f14983562
Profile: codex-rianjs-bot - Posting as: rianjs-bot[bot]
Summary
| Reviewer | Findings |
|---|---|
| automation:ci-release | 0 |
| documentation:docs | 0 |
| go:implementation-tests | 0 |
| policies:conventions | 0 |
| structure:repo-health | 0 |
Reviewer Coverage
automation:ci-release— complete (broad); inspected 4 assigned files (22 inspected across reviewers):.github/workflows/auto-release.yml,.github/workflows/ci.yml,.github/workflows/release.yml,go.mod; skipped: none; constraints: Review limited to assigned workflow and Go module files; shared reusable workflow implementation was not locally available.documentation:docs— complete (broad); inspected 1 assigned file (22 inspected across reviewers):docs/architecture.md; skipped: none; constraints: Reviewed the changed architecture documentation against its referenced current architecture guardrail tests and repo-local development guidance.go:implementation-tests— complete (broad); inspected 18 assigned files (22 inspected across reviewers):go.mod,internal/agents/agents.go,internal/architecture/command_boundaries_test.go,internal/architecture/plannedactions_test.go,internal/architecture/stdlib_imports_test.go,internal/architecture/thread_lifecycle_test.go,internal/benchmark/suite.go,internal/cmd/configcmd/configcmd_test.go,internal/cmd/initcmd/init_linear_editor.go,internal/cmd/initcmd/init_profile_v2.go,internal/cmd/initcmd/init_secrets_management_editor.go,internal/cmd/initcmd/initcmd.go,internal/cmd/initcmd/initcmd_test.go,internal/config/config.go,internal/gitprovider/gitlab/client.go,internal/gitprovider/gitlab/client_test.go,internal/ledger/ledger_test.go,internal/workbench/workbench_test.go; skipped: none; constraints: Focused Go test packages could not build in this workspace because cgo/clang mishandles the checkout path containing spaces; static review and test-source inspection were completed.policies:conventions— complete (broad); inspected 13 assigned files (22 inspected across reviewers):.github/workflows/auto-release.yml,.github/workflows/ci.yml,.github/workflows/release.yml,docs/architecture.md,go.mod,internal/agents/agents.go,internal/cmd/configcmd/configcmd_test.go,internal/cmd/initcmd/init_linear_editor.go,internal/cmd/initcmd/init_profile_v2.go,internal/cmd/initcmd/init_secrets_management_editor.go,internal/cmd/initcmd/initcmd.go,internal/cmd/initcmd/initcmd_test.go,internal/config/config.go; skipped: none; constraints: Focused package tests could not build because the sandbox compiler could not resolve the workspace path; diff and formatting checks completed. Shared cli-common and .github convenience copies were not present, so shared-policy review used the repo-local development guide and visible workflow conventions.structure:repo-health— complete (broad); inspected 15 assigned files (22 inspected across reviewers):docs/architecture.md,go.mod,internal/agents/agents.go,internal/architecture/command_boundaries_test.go,internal/architecture/plannedactions_test.go,internal/architecture/stdlib_imports_test.go,internal/architecture/thread_lifecycle_test.go,internal/cmd/initcmd/init_linear_editor.go,internal/cmd/initcmd/init_profile_v2.go,internal/cmd/initcmd/init_secrets_management_editor.go,internal/cmd/initcmd/initcmd.go,internal/cmd/initcmd/initcmd_test.go,internal/config/config.go,internal/ledger/ledger_test.go,internal/workbench/workbench_test.go; skipped: none; constraints: Focused on structural and automation-health risks; did not review unassigned workflow, GitLab, benchmark, configcmd, or deleted import-test files. Full package tests were constrained by the workspace path/CGO environment; targeted architecture and init editor tests passed.
Inspected files (22)
.github/workflows/auto-release.yml.github/workflows/ci.yml.github/workflows/release.ymldocs/architecture.mdgo.modinternal/agents/agents.gointernal/architecture/command_boundaries_test.gointernal/architecture/plannedactions_test.gointernal/architecture/stdlib_imports_test.gointernal/architecture/thread_lifecycle_test.gointernal/benchmark/suite.gointernal/cmd/configcmd/configcmd_test.gointernal/cmd/initcmd/init_linear_editor.gointernal/cmd/initcmd/init_profile_v2.gointernal/cmd/initcmd/init_secrets_management_editor.gointernal/cmd/initcmd/initcmd.gointernal/cmd/initcmd/initcmd_test.gointernal/config/config.gointernal/gitprovider/gitlab/client.gointernal/gitprovider/gitlab/client_test.gointernal/ledger/ledger_test.gointernal/workbench/workbench_test.go
0 PR discussion threads considered. 0 summarized; 0 resolved.
Completed in 3m 23s | gpt-5.6-terra | cr dev
| Field | Value |
|---|---|
| Model | gpt-5.6-terra |
| Reviewers | automation:ci-release, documentation:docs, go:implementation-tests, policies:conventions, structure:repo-health |
| Engine | codex_cli · gpt-5.6-terra |
| Reviewed by | cr · rianjs-bot[bot] |
| Duration | 3m 23s wall · 8m 09s compute |
| Cost | unavailable |
| Tokens | 2.7M in / 17.2k out |
Per-workstream usage
orchestrator-selection— gpt-5.6-terra- In: 18.5k
- Out: 702
- Cache read: 11.0k
- Cache create: unavailable
- Cost: unavailable
- Duration: 16s
automation:ci-release— gpt-5.6-terra- In: 127.3k
- Out: 1.6k
- Cache read: 99.3k
- Cache create: unavailable
- Cost: unavailable
- Duration: 42s
documentation:docs— gpt-5.6-terra- In: 120.4k
- Out: 986
- Cache read: 86.0k
- Cache create: unavailable
- Cost: unavailable
- Duration: 28s
go:implementation-tests— gpt-5.6-terra- In: 1.0M
- Out: 5.8k
- Cache read: 917.8k
- Cache create: unavailable
- Cost: unavailable
- Duration: 2m 49s
policies:conventions— gpt-5.6-terra- In: 233.6k
- Out: 2.6k
- Cache read: 183.8k
- Cache create: unavailable
- Cost: unavailable
- Duration: 1m 13s
structure:repo-health— gpt-5.6-terra- In: 1.2M
- Out: 5.5k
- Cache read: 1.0M
- Cache create: unavailable
- Cost: unavailable
- Duration: 2m 32s
orchestrator-rollup— gpt-5.6-terra- In: 21.5k
- Out: 42
- Cache read: 18.2k
- Cache create: unavailable
- Cost: unavailable
- Duration: 5s
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The CLI duplicated terminal editor and architecture mechanics, had unreachable init state, and left runtime and CI defaults dependent on mutable or one-time configuration.
Changes
go.yaml.in/yaml/v3v3.0.5.b6382514b809d960c6fbdc85745a60c14cde04f1.The shared automation pin is prepared in open-cli-collective/.github#45, which pins its nested action graph and validates the new self-repository references.
Validation
make buildpassed from the committed tree.make testpassed across the full repository.make lintpassed with 0 issues.go mod verifypassed.actionlintpassed for the caller workflows.--version/--helpsmoke tests passed; the temporary-config PTY smoke covered init navigation, staging, back, and discard without real credentials.