Skip to content

fix: harden runtime defaults and simplify init editors - #612

Merged
rianjs merged 7 commits into
mainfrom
refactor/framework-alignment
Sep 15, 2026
Merged

rianjs merged 7 commits into
mainfrom
refactor/framework-alignment

Conversation

@rianjs

@rianjs rianjs commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

Problem

The CLI duplicated terminal editor and architecture mechanics, had unreachable init state, and left runtime and CI defaults dependent on mutable or one-time configuration.

Changes

  • Bound the GitLab HTTP client and add cancellation/cascade coverage alongside the SQLite startup fix merged from main.
  • Remove unreachable secrets-editor state and brittle architecture prescriptions; fix eight cleanup registrations while keeping dependency and lifecycle boundaries.
  • Share the pinned Bubbles input/textarea components across init editors, preserve staged writes and secret masking, and wrap terminal text by ANSI cell width.
  • Migrate direct YAML use to maintained go.yaml.in/yaml/v3 v3.0.5.
  • Pin codereview workflow dependencies to full commit SHAs, including the shared automation commit b6382514b809d960c6fbdc85745a60c14cde04f1.

The shared automation pin is prepared in open-cli-collective/.github#45, which pins its nested action graph and validates the new self-repository references.

Validation

  • make build passed from the committed tree.
  • make test passed across the full repository.
  • make lint passed with 0 issues.
  • go mod verify passed.
  • actionlint passed for the caller workflows.
  • All caller action references were audited as full 40 character SHAs and the shared reference was checked against PR feat(outbox): add host-agnostic post phase #45's head OID.
  • Built binary --version/--help smoke tests passed; the temporary-config PTY smoke covered init navigation, staging, back, and discard without real credentials.

@rianjs rianjs changed the title refactor: align framework usage and simplify architecture refactor: harden runtime defaults and simplify init editors Sep 15, 2026
@rianjs rianjs changed the title refactor: harden runtime defaults and simplify init editors fix: harden runtime defaults and simplify init editors Sep 15, 2026

@rianjs-bot rianjs-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated PR Review

Reviewed commit: 226f14983562
Profile: codex-rianjs-bot - Posting as: rianjs-bot[bot]

Summary

Reviewer Findings
automation:ci-release 0
documentation:docs 0
go:implementation-tests 0
policies:conventions 0
structure:repo-health 0

Reviewer Coverage

  • automation:ci-release — complete (broad); inspected 4 assigned files (22 inspected across reviewers): .github/workflows/auto-release.yml, .github/workflows/ci.yml, .github/workflows/release.yml, go.mod; skipped: none; constraints: Review limited to assigned workflow and Go module files; shared reusable workflow implementation was not locally available.
  • documentation:docs — complete (broad); inspected 1 assigned file (22 inspected across reviewers): docs/architecture.md; skipped: none; constraints: Reviewed the changed architecture documentation against its referenced current architecture guardrail tests and repo-local development guidance.
  • go:implementation-tests — complete (broad); inspected 18 assigned files (22 inspected across reviewers): go.mod, internal/agents/agents.go, internal/architecture/command_boundaries_test.go, internal/architecture/plannedactions_test.go, internal/architecture/stdlib_imports_test.go, internal/architecture/thread_lifecycle_test.go, internal/benchmark/suite.go, internal/cmd/configcmd/configcmd_test.go, internal/cmd/initcmd/init_linear_editor.go, internal/cmd/initcmd/init_profile_v2.go, internal/cmd/initcmd/init_secrets_management_editor.go, internal/cmd/initcmd/initcmd.go, internal/cmd/initcmd/initcmd_test.go, internal/config/config.go, internal/gitprovider/gitlab/client.go, internal/gitprovider/gitlab/client_test.go, internal/ledger/ledger_test.go, internal/workbench/workbench_test.go; skipped: none; constraints: Focused Go test packages could not build in this workspace because cgo/clang mishandles the checkout path containing spaces; static review and test-source inspection were completed.
  • policies:conventions — complete (broad); inspected 13 assigned files (22 inspected across reviewers): .github/workflows/auto-release.yml, .github/workflows/ci.yml, .github/workflows/release.yml, docs/architecture.md, go.mod, internal/agents/agents.go, internal/cmd/configcmd/configcmd_test.go, internal/cmd/initcmd/init_linear_editor.go, internal/cmd/initcmd/init_profile_v2.go, internal/cmd/initcmd/init_secrets_management_editor.go, internal/cmd/initcmd/initcmd.go, internal/cmd/initcmd/initcmd_test.go, internal/config/config.go; skipped: none; constraints: Focused package tests could not build because the sandbox compiler could not resolve the workspace path; diff and formatting checks completed. Shared cli-common and .github convenience copies were not present, so shared-policy review used the repo-local development guide and visible workflow conventions.
  • structure:repo-health — complete (broad); inspected 15 assigned files (22 inspected across reviewers): docs/architecture.md, go.mod, internal/agents/agents.go, internal/architecture/command_boundaries_test.go, internal/architecture/plannedactions_test.go, internal/architecture/stdlib_imports_test.go, internal/architecture/thread_lifecycle_test.go, internal/cmd/initcmd/init_linear_editor.go, internal/cmd/initcmd/init_profile_v2.go, internal/cmd/initcmd/init_secrets_management_editor.go, internal/cmd/initcmd/initcmd.go, internal/cmd/initcmd/initcmd_test.go, internal/config/config.go, internal/ledger/ledger_test.go, internal/workbench/workbench_test.go; skipped: none; constraints: Focused on structural and automation-health risks; did not review unassigned workflow, GitLab, benchmark, configcmd, or deleted import-test files. Full package tests were constrained by the workspace path/CGO environment; targeted architecture and init editor tests passed.
Inspected files (22)
  • .github/workflows/auto-release.yml
  • .github/workflows/ci.yml
  • .github/workflows/release.yml
  • docs/architecture.md
  • go.mod
  • internal/agents/agents.go
  • internal/architecture/command_boundaries_test.go
  • internal/architecture/plannedactions_test.go
  • internal/architecture/stdlib_imports_test.go
  • internal/architecture/thread_lifecycle_test.go
  • internal/benchmark/suite.go
  • internal/cmd/configcmd/configcmd_test.go
  • internal/cmd/initcmd/init_linear_editor.go
  • internal/cmd/initcmd/init_profile_v2.go
  • internal/cmd/initcmd/init_secrets_management_editor.go
  • internal/cmd/initcmd/initcmd.go
  • internal/cmd/initcmd/initcmd_test.go
  • internal/config/config.go
  • internal/gitprovider/gitlab/client.go
  • internal/gitprovider/gitlab/client_test.go
  • internal/ledger/ledger_test.go
  • internal/workbench/workbench_test.go

0 PR discussion threads considered. 0 summarized; 0 resolved.


Completed in 3m 23s | gpt-5.6-terra | cr dev
Field Value
Model gpt-5.6-terra
Reviewers automation:ci-release, documentation:docs, go:implementation-tests, policies:conventions, structure:repo-health
Engine codex_cli · gpt-5.6-terra
Reviewed by cr · rianjs-bot[bot]
Duration 3m 23s wall · 8m 09s compute
Cost unavailable
Tokens 2.7M in / 17.2k out

Per-workstream usage

  • orchestrator-selection — gpt-5.6-terra
    • In: 18.5k
    • Out: 702
    • Cache read: 11.0k
    • Cache create: unavailable
    • Cost: unavailable
    • Duration: 16s
  • automation:ci-release — gpt-5.6-terra
    • In: 127.3k
    • Out: 1.6k
    • Cache read: 99.3k
    • Cache create: unavailable
    • Cost: unavailable
    • Duration: 42s
  • documentation:docs — gpt-5.6-terra
    • In: 120.4k
    • Out: 986
    • Cache read: 86.0k
    • Cache create: unavailable
    • Cost: unavailable
    • Duration: 28s
  • go:implementation-tests — gpt-5.6-terra
    • In: 1.0M
    • Out: 5.8k
    • Cache read: 917.8k
    • Cache create: unavailable
    • Cost: unavailable
    • Duration: 2m 49s
  • policies:conventions — gpt-5.6-terra
    • In: 233.6k
    • Out: 2.6k
    • Cache read: 183.8k
    • Cache create: unavailable
    • Cost: unavailable
    • Duration: 1m 13s
  • structure:repo-health — gpt-5.6-terra
    • In: 1.2M
    • Out: 5.5k
    • Cache read: 1.0M
    • Cache create: unavailable
    • Cost: unavailable
    • Duration: 2m 32s
  • orchestrator-rollup — gpt-5.6-terra
    • In: 21.5k
    • Out: 42
    • Cache read: 18.2k
    • Cache create: unavailable
    • Cost: unavailable
    • Duration: 5s

@rianjs
rianjs marked this pull request as ready for review September 15, 2026 15:35
@rianjs
rianjs merged commit 04f0193 into main Sep 15, 2026
10 checks passed
@rianjs
rianjs deleted the refactor/framework-alignment branch September 15, 2026 19:24
@rianjs
rianjs restored the refactor/framework-alignment branch September 15, 2026 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant