Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cr reviewcould exit as already approved or already complete aftercr respondposted newer inline replies. GitHub records those replies asCOMMENTEDreview events, so the merge gate correctly required a newer verdict while the normal review command refused to produce one.This makes both live-review fast paths select the latest approval, change request, or comment from the posting identity. A newer comment now starts a fresh review; a latest approval or change request keeps the existing behavior.
Testing
go test ./internal/gateio ./internal/app ./internal/cmd/reviewcmdgolangci-lint runmake checkpasses through the changed packages; the local installed-Pi compatibility test fails because that Pi version rejects--no-builtin-toolsand--no-approve